User tests: Successful: Unsuccessful:
Pull Request for Issue # .
If you discover a plugin/module/template which have the changelog
then no changelog info is saved
set the changelog vaule
install this plugin https://github.com/alikon/testcom/raw/main/plugins/content/export/plg_content_export-1.0.1.zip with Discover
install this module https://github.com/alikon/testcom/raw/main/modules/mod_jstats-1.0.0.zip with Discover
install this template template_test.zip with Discover
no changelog link available on Extensions: Manage
changelog link available on Extensions: Manage
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
didn't checked yet with other extensions type, cause few of them use the changelog
i'll check it later , did you know some extensions that use changelog ?
@alikon jCode Syntax Highlighter 1.3.0 uses.
plg_jcodesyntaxhighlighter_1.3.0.zip
UPD
Sorry, you probably meant a different type of extensions.
yes looking for modules, components
@alikon Installed your Plugin, activated Patchtester, but got only:
Other extensions: Pinged: @PhocaCz. Thanks
@ChristineWk you need to click on the version number (1.0.1) to open the modal with the changelog
and you need to install it via discover not normal installation
@Kostelano can you share it please
@ChristineWk you need to click on the version number (1.0.1) to open the modal with the changelog and you need to install it via discover not normal installation
Ah ... when clicking on version number the modal opened with the changelog info.
Will delete plugin and try with discover.
Labels |
Added:
?
|
Title |
|
@alikon Sorry, I can't understand the changes to the PR with the screenshots in your header post. As far as I understand, it was about displaying a link to the changelog BEFORE installing the extension on the discovery page. Your screenshots are from another section.
In addition, having tested the PR, I cannot get a successful test. The extension version is still not clickable on the discovery page.
Please explain. Maybe I'm not interpreting PR in the right way.
the 2nd screenshot is after discover installtion then go to Extension-> Manage
I have tested this item
Thanks, now I understand.
Yes, PR works great, I confirm. BEFORE - "not transferred" information with changelog, AFTER - "transferred".
I send a successful test. However, I would be happy if we could implement the same scenario for templates, and for components.
for component should be already ok https://github.com/joomla/joomla-cms/blob/4.2-dev/libraries/src/Installer/Adapter/ComponentAdapter.php#L844
for template i need a template with changelog to test cause seems missing
I have already tested, you can safely add the same line to the corresponding file for the template, it is missing there.
Testing is easy - I just copied the Cassiopeia template directory, renamed it to template_test, added a link to the changelog, and installed the template.
Test and add a line please, I will resubmit a successful test. Thank you.
OK, the Plugin is tested successfully now:
For the loading of module I get an error 404
Title |
|
added the template extensions type
I have tested this item
@ChristineWk, could you check and send the test, since you have already paid attention to this PR?
@Kostelano
a) yes test Plugin was/is successful.
b) as I wrote: loading mod_jstats ... get error 404.
c) Loaded template_test OK, but in Backend not found under discover. Maybe installed on wrong place (FTP)?
@ChristineWk Find template_test on the extension management page and look at the version - if it's clickable, then your test is successful. You do not need any other pages in this PR. Only managing extensions and having a clickable version.
@Kostelano The version was clickable in the plugin test, but not in the template_test.
That's why I made a screenshot of it where there is no underlined line in blue.
@ChristineWk , see Extensions: Manage
@sandewt Thanks, but I showed in the screenshot above that I was in extensions: Manage.
The zips from the instructions here didn't work.
I tried it with other extensions which @ReLater provided me with the changelogs and test instructions!
A change also had to be made in adapter.php for module and template because I couldn't use the patch tester for that.
It wasn't easy for me, but thanks to his support, I succeeded.
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Before I merge this can someone please just confirm that this PR doesn't cause any issues with older extensions without a changelog?
Labels |
Added:
?
|
I have tested this item
Installed the upcoming module from DPCalendar which doesn't have a changelog entry.
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-09-15 21:12:57 |
Closed_By | ⇒ | fancyFranci |
Thank you! Nice to see the changelogs now :)
does this change need to be applied to all extensions?