? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
2 Aug 2022

Pull Request for Issue # .
If you discover a plugin/module/template which have the changelog then no changelog info is saved

Summary of Changes

set the changelog vaule

Testing Instructions

install this plugin https://github.com/alikon/testcom/raw/main/plugins/content/export/plg_content_export-1.0.1.zip with Discover

install this module https://github.com/alikon/testcom/raw/main/modules/mod_jstats-1.0.0.zip with Discover

install this template template_test.zip with Discover

Actual result BEFORE applying this Pull Request

no changelog link available on Extensions: Manage

image

Expected result AFTER applying this Pull Request

changelog link available on Extensions: Manage

image

avatar alikon alikon - open - 2 Aug 2022
avatar alikon alikon - change - 2 Aug 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Aug 2022
Category Libraries
avatar brianteeman
brianteeman - comment - 2 Aug 2022

does this change need to be applied to all extensions?

avatar alikon
alikon - comment - 2 Aug 2022

didn't checked yet with other extensions type, cause few of them use the changelog
i'll check it later , did you know some extensions that use changelog ?

avatar Kostelano
Kostelano - comment - 2 Aug 2022

@alikon jCode Syntax Highlighter 1.3.0 uses.

plg_jcodesyntaxhighlighter_1.3.0.zip

UPD
Sorry, you probably meant a different type of extensions.

avatar alikon
alikon - comment - 2 Aug 2022

yes looking for modules, components

avatar ChristineWk
ChristineWk - comment - 2 Aug 2022

@alikon Installed your Plugin, activated Patchtester, but got only:

screen shot 2022-08-02 at 10 38 20

Other extensions: Pinged: @PhocaCz. Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38372.

avatar alikon
alikon - comment - 2 Aug 2022

@ChristineWk you need to click on the version number (1.0.1) to open the modal with the changelog
and you need to install it via discover not normal installation

avatar Kostelano
Kostelano - comment - 2 Aug 2022

No, at least for modules it does not work. Probably for components too. I added the <changelogurl> tag beforehand.

Screenshot_1

avatar alikon
alikon - comment - 2 Aug 2022

@Kostelano can you share it please

avatar ChristineWk
ChristineWk - comment - 2 Aug 2022

@ChristineWk you need to click on the version number (1.0.1) to open the modal with the changelog and you need to install it via discover not normal installation

Ah ... when clicking on version number the modal opened with the changelog info.
Will delete plugin and try with discover.

avatar Kostelano
Kostelano - comment - 2 Aug 2022

@alikon Sorry, I already left the PC. Just add your own line from the plugin to the manifest of any module/component.

avatar alikon alikon - change - 2 Aug 2022
Labels Added: ?
avatar ChristineWk
ChristineWk - comment - 2 Aug 2022

Plugin Installed via FTP and checked Discover:

pr38372-plugin-via-discover

After: "Install":

pr38372-alikon-install-discover

@alikon Sorry, when doing something wrong. (Usually never installed before via Discover).

avatar alikon alikon - change - 2 Aug 2022
Title
[4] missing changelog when discover a plugin
[4] missing changelog when discover a plugin/module
avatar alikon alikon - edited - 2 Aug 2022
avatar alikon alikon - change - 2 Aug 2022
The description was changed
avatar alikon alikon - edited - 2 Aug 2022
avatar Kostelano
Kostelano - comment - 2 Aug 2022

@alikon Sorry, I can't understand the changes to the PR with the screenshots in your header post. As far as I understand, it was about displaying a link to the changelog BEFORE installing the extension on the discovery page. Your screenshots are from another section.

In addition, having tested the PR, I cannot get a successful test. The extension version is still not clickable on the discovery page.

Please explain. Maybe I'm not interpreting PR in the right way.

avatar alikon
alikon - comment - 2 Aug 2022

the 2nd screenshot is after discover installtion then go to Extension-> Manage

avatar Kostelano
Kostelano - comment - 2 Aug 2022

I have tested this item successfully on afaedaf

Thanks, now I understand.
Yes, PR works great, I confirm. BEFORE - "not transferred" information with changelog, AFTER - "transferred".

I send a successful test. However, I would be happy if we could implement the same scenario for templates, and for components.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38372.

avatar Kostelano Kostelano - test_item - 2 Aug 2022 - Tested successfully
avatar alikon
alikon - comment - 2 Aug 2022

for template i need a template with changelog to test cause seems missing

avatar Kostelano
Kostelano - comment - 2 Aug 2022

I have already tested, you can safely add the same line to the corresponding file for the template, it is missing there.

Testing is easy - I just copied the Cassiopeia template directory, renamed it to template_test, added a link to the changelog, and installed the template.

Test and add a line please, I will resubmit a successful test. Thank you.

template_test.zip

avatar ChristineWk
ChristineWk - comment - 2 Aug 2022

OK, the Plugin is tested successfully now:
screen shot 2022-08-02 at 20 34 04


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38372.

For the loading of module I get an error 404

avatar alikon alikon - change - 3 Aug 2022
Title
[4] missing changelog when discover a plugin/module
[4] missing changelog when discover a plugin/module/template
avatar alikon alikon - edited - 3 Aug 2022
avatar alikon alikon - change - 3 Aug 2022
The description was changed
avatar alikon alikon - edited - 3 Aug 2022
avatar alikon
alikon - comment - 3 Aug 2022

added the template extensions type

avatar Kostelano
Kostelano - comment - 3 Aug 2022

I have tested this item successfully on 70a0738


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38372.

avatar Kostelano Kostelano - test_item - 3 Aug 2022 - Tested successfully
avatar Kostelano
Kostelano - comment - 3 Aug 2022

@ChristineWk, could you check and send the test, since you have already paid attention to this PR?

avatar ChristineWk
ChristineWk - comment - 3 Aug 2022

@Kostelano
a) yes test Plugin was/is successful.
b) as I wrote: loading mod_jstats ... get error 404.
c) Loaded template_test OK, but in Backend not found under discover. Maybe installed on wrong place (FTP)?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38372.

avatar Kostelano
Kostelano - comment - 3 Aug 2022

@ChristineWk

  1. https://github.com/alikon/testcom/blob/main/modules/mod_jstats/mod_jstats-1.0.0.zip
  2. Throw the template into the directory with templates. Where is the Cassiopeia.
avatar ChristineWk
ChristineWk - comment - 3 Aug 2022
  1. OK installed via discover, but ...... sorry.

screen shot 2022-08-03 at 14 47 14
screen shot 2022-08-03 at 14 47 29


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38372.

avatar Kostelano
Kostelano - comment - 3 Aug 2022

@ChristineWk Find template_test on the extension management page and look at the version - if it's clickable, then your test is successful. You do not need any other pages in this PR. Only managing extensions and having a clickable version.

avatar ChristineWk
ChristineWk - comment - 3 Aug 2022

@Kostelano The version was clickable in the plugin test, but not in the template_test.
That's why I made a screenshot of it where there is no underlined line in blue.

avatar sandewt
sandewt - comment - 4 Aug 2022

@ChristineWk , see Extensions: Manage
screen shot 2022-08-04 at 12 33 38


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38372.

avatar ChristineWk
ChristineWk - comment - 5 Aug 2022

@sandewt Thanks, but I showed in the screenshot above that I was in extensions: Manage.
The zips from the instructions here didn't work.

I tried it with other extensions which @ReLater provided me with the changelogs and test instructions!
A change also had to be made in adapter.php for module and template because I couldn't use the patch tester for that.

It wasn't easy for me, but thanks to his support, I succeeded.
testtemplate-erfolgreich-05aug-nach-adapterphp
testmodul-erfolgreich-nach-adapterphp

avatar ChristineWk
ChristineWk - comment - 5 Aug 2022

I have tested this item successfully on 70a0738


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38372.

avatar alikon alikon - change - 5 Aug 2022
Status Pending Ready to Commit
avatar ChristineWk ChristineWk - test_item - 5 Aug 2022 - Tested successfully
avatar alikon
alikon - comment - 6 Aug 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38372.

avatar wilsonge
wilsonge - comment - 5 Sep 2022

Before I merge this can someone please just confirm that this PR doesn't cause any issues with older extensions without a changelog?

avatar laoneo
laoneo - comment - 9 Sep 2022

@wilsonge you can install any module of DPCalendar for a test.

avatar laoneo laoneo - change - 10 Sep 2022
Labels Added: ?
avatar laoneo
laoneo - comment - 10 Sep 2022

I have tested this item successfully on 5b0f413

Installed the upcoming module from DPCalendar which doesn't have a changelog entry.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38372.

avatar laoneo laoneo - test_item - 10 Sep 2022 - Tested successfully
avatar fancyFranci fancyFranci - change - 15 Sep 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-09-15 21:12:57
Closed_By fancyFranci
avatar fancyFranci fancyFranci - close - 15 Sep 2022
avatar fancyFranci fancyFranci - merge - 15 Sep 2022
avatar fancyFranci
fancyFranci - comment - 15 Sep 2022

Thank you! Nice to see the changelogs now :)

Add a Comment

Login with GitHub to post a comment