? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
31 Jul 2022

Removes the property float:left as it is not used due to the additional class float-start applied to the same element. (makes it easier to convert to use logical properties if we don't have unused css)

image

avatar brianteeman brianteeman - open - 31 Jul 2022
avatar brianteeman brianteeman - change - 31 Jul 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Jul 2022
Category Repository NPM Change
avatar Fedik
Fedik - comment - 31 Jul 2022

hm, maybe it for cases when BS not used, and custom template does not have this class? then it can hurt such templates a litle

avatar brianteeman
brianteeman - comment - 31 Jul 2022

hm, maybe it for cases when BS not used, and custom template does not have this class? then it can hurt such templates a litle

then we should never use any bootstrap utility classes in the frontend - and we do - alot

avatar Fedik
Fedik - comment - 31 Jul 2022

I have tested this item successfully on d9617b7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38350.

avatar Fedik Fedik - test_item - 31 Jul 2022 - Tested successfully
avatar Quy
Quy - comment - 1 Aug 2022

I have tested this item successfully on d9617b7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38350.

avatar Quy Quy - change - 1 Aug 2022
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 1 Aug 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38350.

avatar Quy Quy - test_item - 1 Aug 2022 - Tested successfully
avatar wilsonge wilsonge - change - 5 Sep 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-09-05 12:07:34
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 5 Sep 2022
avatar wilsonge wilsonge - merge - 5 Sep 2022
avatar wilsonge
wilsonge - comment - 5 Sep 2022

Thanks!

avatar brianteeman
brianteeman - comment - 5 Sep 2022

thanks

Add a Comment

Login with GitHub to post a comment