[#38341] - Do not show the webauthn form on the registration page
- Fixed in Code Base
- 31 Jul 2022
- Medium
- Build: 4.2-dev
- # 38341
- Diff
- roland-d:feature/38260-add-missing-string
User tests: Successful: Unsuccessful:
Pull Request for Issue #38260 .
Summary of Changes
This change adds:
- the missing language string in case a user account cannot be found
- does not show the webauthn form on the user registration page
- Removed an unused use statement
Testing Instructions
See issue #38260 for the excellent test instructions, picture by picture.
- Take the steps as outlined in #38260
- Confirm you see the Web Authentication on the registration page and the missing language string
- Apply the patch
- Refresh the registration page and the Web Authentication should be gone
- Login as a user
- Go to edit your profile
- Verify you see the Web Authentication form
Actual result BEFORE applying this Pull Request
The Web Authentication form is shown on the user registration page
Expected result AFTER applying this Pull Request
The Web Authentication form is not shown on the user registration page
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Front End Plugins |
You have a mix of tabs and spaces for the indentations
| Labels |
Added:
Language Change
?
|
||
@brianteeman Thank you, should be fixed.
@nikosdion No problem, thank you for responding. Enjoy the holidays.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38341.
I have tested this item
✅ successfully on 35cfb41Works the way it shouldThis comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38341.
@obuisard can you please run a new test. thanks
@tecpromotion No need for @obuisard to test again because the only change after his test was code style only (Just reviews by me). I will restore the test in the issue tracker so it’s properly counted.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38341.
@tecpromotion No need for @obuisard to test again because the only change after his test was code style only (Just reviews by me). I will restore the test in the issue tracker so it’s properly counted.
Thanks @richard67.
Please add label RTC after restore the test.
This PR is still coming in 4.2.0 and the translators can then add the language string asap.
@tecpromotion No need to remind me to set RTC. I know what to do.
I‘ve set the release blocker label as inherited from the issue.
fancyFranci
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-07-31 19:43:25 |
| Closed_By | ⇒ | fancyFranci | |
| Labels |
Added:
?
Release Blocker
|
||
I have tested this item✅ successfully on 35cfb41
Works the way it should
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38341.