[#38337] - full width spacer hr line
- Closed
- 10 Jan 2023
- Medium
- Build: 4.2-dev
- # 38337
- Diff
- svanschu:4.2-dev
User tests: Successful: Unsuccessful:
Pull Request for Issue # . No issue created for it.
My first Joomla! PR ...
Summary of Changes
In the current Joomla 4 backend the space hr form field only creates a line partially.
With this changes the hr line is again on the full width and looks much better as spacer.
The changes are only made for the hr=true case, because if nothing is shown it doesn't matter.
If text is used it only gets displayed as label and hr=false need to be set.
For bigger text the note form field should be used.
Testing Instructions
Actual result BEFORE applying this Pull Request
Open Modules: Articles - Category Filtering-Options and you see a small line space left aligned.
Expected result AFTER applying this Pull Request
After the patch you should see a full width line
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change Libraries |
| Labels |
Added:
NPM Resource Changed
?
|
||
Above the function getInput() there is a comment:
Method to get the field input markup for a spacer. The spacer does not have accept input.
so adding code here seems wrong to me. And the html code is already being created in the function getLabel()
I think a change of the CSS should be enough to get a 100% wide line
.spacer hr { width: 100%; } .control-group.field-spacer .control-label { width: 100%; }
Above the function
getInput()there is a comment:Method to get the field input markup for a spacer. The spacer does not have accept input.so adding code here seems wrong to me. And the html code is already being created in the functiongetLabel()I think a change of the CSS should be enough to get a 100% wide line
.spacer hr { width: 100%; } .control-group.field-spacer .control-label { width: 100%; }
Pure CSS is not enough. Either this patch or you need to rewrite the spacer field completely to be like the note field. with own HTML without the normal FormField behavior.
Content / Options
With CSS only
Can you give an example where that doesn't work?
Css works for me.
Seems to be a "old" fild. Is there a reason for the fixed width of 380px? And for bootstrap popOver?
@drmenzelit yes you're right sorry.
@chmst yes that's a pretty old field. I thought about to rewrite it so it really only makes a space or a line without the option to enter text, because since J3.1 we have the note field which adds text full width.
What do you think?
@svanschu thank you very much for all your work and commitment here.
Unfortunately thsi PR cannot be accepted, it would be a b/c break, as until now the text was displayed and could be used by 3rd party developers in their forms.
Now as you have made your first PR, you know how this works and we are looking forward to new PRs from you :)
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-01-10 22:36:23 |
| Closed_By | ⇒ | chmst |
I have tested this item✅ successfully on 4568771
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38337.