? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
28 Jul 2022

In the past there were some issues with folders with a . in them. I forget what the issue was. As a result choices.js was stored in choicesjs to avoid this.

This pr does the same for hotkeys.js

@fancyFranci

avatar brianteeman brianteeman - open - 28 Jul 2022
avatar brianteeman brianteeman - change - 28 Jul 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jul 2022
Category Repository
5eea7ef 28 Jul 2022 avatar brianteeman .
avatar brianteeman brianteeman - change - 28 Jul 2022
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jul 2022
Category Repository Repository Front End Plugins
avatar Fedik
Fedik - comment - 30 Jul 2022

I have tested this item successfully on 5eea7ef


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38334.

avatar Fedik Fedik - test_item - 30 Jul 2022 - Tested successfully
avatar Kostelano
Kostelano - comment - 14 Aug 2022

I have tested this item successfully on 63987b3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38334.

avatar Kostelano Kostelano - test_item - 14 Aug 2022 - Tested successfully
avatar brianteeman
brianteeman - comment - 14 Aug 2022

This PR will be closed in 24 hours. There is no point in it existing once 4.2 is released. Just dont say no one knew the folder name was a problem and you have to write a complex pr to fix the mess

avatar Quy Quy - change - 15 Aug 2022
Status Pending Ready to Commit
avatar Quy
Quy - comment - 15 Aug 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38334.

avatar Quy Quy - alter_testresult - 15 Aug 2022 - Fedik: Not tested
avatar Quy Quy - alter_testresult - 15 Aug 2022 - Fedik: Tested successfully
avatar Quy Quy - change - 15 Aug 2022
Labels Added: ?
avatar roland-d roland-d - change - 15 Aug 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-08-15 17:41:10
Closed_By roland-d
avatar roland-d roland-d - close - 15 Aug 2022
avatar roland-d roland-d - merge - 15 Aug 2022
avatar roland-d
roland-d - comment - 15 Aug 2022

Thank you. The issue with a dot is described here: #22263 (comment)

avatar brianteeman
brianteeman - comment - 15 Aug 2022

well at least it got merged in the end

Add a Comment

Login with GitHub to post a comment