[#38317] - [3.10] Workaround the a bit off monthsUntilEOS calculation
- Fixed in Code Base
- 22 Jul 2022
- Medium
- Build: 3.10-dev
- # 38317
- Diff
- zero-24:monthcalculation
User tests: Successful: Unsuccessful:
Summary of Changes
The message checks for the EOS plugin depend on the monthsUntilEOS but that calculation is a bit off.
Testing Instructions
- Install 3.10
- Notice the "securrity only mode" message
- Apply this patch
- you get the Info 2 message
- modify the eos setting to: const EOS_DATE = '2023-07-17'; (would mean we would be actually in sec only mode already)#
- notice the "securrity only mode" message came up again
Actual result BEFORE applying this Pull Request
The messages where one month to early
Expected result AFTER applying this Pull Request
The messages come on the expected months
Documentation Changes Required
n.a.
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
?
|
||
Unless there is going to be an update released in the next few weeks this pr (while correct) is pointless.
there will be a one more release :-)
I forgot about the 6 month notice
I have tested this item
I've played around a bit more with the EOS_DATE than described in the testing instructions.
Due to the calculation of the $monthsUntilEOS with some kind of average month length in days (see https://github.com/joomla/joomla-cms/blob/3.10-dev/plugins/quickicon/eos310/eos310.php#L77 ) the message changes are not accurate by the day, but accurate enough:
const EOS_DATE = '2022-07-22';
=> Support has ended
const EOS_DATE = '2022-07-23';
const EOS_DATE = '2023-01-21';
=> Support ends on ... for Joomla 3.10. Migrate to Joomla 4 as soon as possible.
const EOS_DATE = '2023-01-22';
const EOS_DATE = '2023-07-23';
=> Joomla 3.10 has entered security only mode. Support ends ... Start planning to migrate to Joomla 4 today.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38317.
@tecpromotion Could you redo your test? Thanks in advance.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38317.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38317.
Merging thanks guys :)
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-07-22 10:38:22 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on ba9c039
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38317.