[#38309] - Remove filename from mod_quickicon manifest
- Fixed in Code Base
- 29 Jul 2022
- Medium
- Build: 4.2-dev
- # 38309
- Diff
- richard67:4.2-dev-fix-mod-quickicon-manifest-xml
User tests: Successful: Unsuccessful:
Pull Request for Issue #38307 .
Summary of Changes
Removes the obsolete <filename module="mod_quickicon">mod_quickicon.php</filename> from file "administrator/modules/mod_quickicon/mod_quickicon.xml" and use the module attribute on the "services" folder like it is correct here for another module: https://github.com/joomdonation/joomla-cms/blob/4.2-dev/modules/mod_articles_latest/mod_articles_latest.xml#L14
I haven't deeply checked if there is already a PR which solves that. On a quick search I haven't found one. If there is one, I will of course close mine in favour of that one.
Testing Instructions
Code review and check that quickicon modules are still working in backend.
Actual result BEFORE applying this Pull Request
Quickicon modules are working but the manifest contains the obsolete <filename> element for a not existing file.
Expected result AFTER applying this Pull Request
Quickicon modules are still working and the manifest XML is correct.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
I have tested this item
code review, could not find another issue/pr either.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38309.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38309.
| Labels |
Added:
?
?
Maintainers Checked
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-07-29 19:27:05 |
| Closed_By | ⇒ | roland-d |
Thank you.
I have tested this item✅ successfully on fdaa4cd
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38309.