Feature Language Change PR-5.0-dev ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
17 Jul 2022

Following feedback this PR adds two new shortcut keys
Save & New
Save as Copy

image

avatar brianteeman brianteeman - open - 17 Jul 2022
avatar brianteeman brianteeman - change - 17 Jul 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jul 2022
Category Administration Language & Strings Front End Plugins
d8c9e17 17 Jul 2022 avatar brianteeman cs
avatar brianteeman brianteeman - change - 17 Jul 2022
Labels Added: Language Change ?
avatar Kostelano
Kostelano - comment - 18 Jul 2022

I can not "catch" the work of new combinations.

Moreover, they can work quite well, but the speed / quality of the plugin is poor. By pressing other combinations about 8-10 times, the combination works for me a maximum of a couple of times. In this situation, by pressing J+SN, I caught J+S a couple of times and that's it.

Given this, I would prefer to use a combination of 2 buttons at most.

avatar Kostelano
Kostelano - comment - 18 Jul 2022

Just thoughts. Given the prospect of expanding combinations for the plugin in the future + simplifying so that any combination consists of simple 2 buttons, we could divide them into groups.

For example, group J (base):

J + S Search,
J + O Options,
J + H Help,
J + M Toggle Menu,
J + Х Overview,
J + D Home Dashboard,

Group H (conditionally ... The letter A from the word actions will be too close to labels.):

H + S Save,
H + C Save & Close,
H + N Save & New,
H + D Save & Copy,
H + Q Cancel/Close

This will make it easier to select a paired letter (label).

Again, all of this only makes sense if the plugin is going to be extended in the core.

avatar brianteeman
brianteeman - comment - 18 Jul 2022

can't say i am a fan. much better to just have one key act as the trigger. Also I cant replicate your issue with activating the shortcuts

avatar chmst
chmst - comment - 23 Oct 2022

Moreover, they can work quite well, but the speed / quality of the plugin is poor. By pressing other combinations about 8-10 times, the combination works for me a maximum of a couple of times.

Probably you pressed the keys too fast? There must be a small time between. You can manipulate the time in the plugin.

About grouping the keys: For normal users the grouping is not obvious (remember: don't make me think).
My opinion is, that users have a kind of reflex in pressing shortcut keys ... always first J ..and should not think about which one could be the first key.

avatar HLeithner
HLeithner - comment - 2 May 2023

This pull request has been automatically rebased to 5.0-dev.

avatar brianteeman brianteeman - change - 8 Sep 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-09-08 11:51:21
Closed_By brianteeman
Labels Added: Feature PR-5.0-dev ?
Removed: ?
avatar brianteeman brianteeman - close - 8 Sep 2023

Add a Comment

Login with GitHub to post a comment