? Error

User tests: Successful: Unsuccessful:

avatar sarciszewski
sarciszewski
25 Jun 2014

https://www.isecpartners.com/blog/2011/february/double-hmac-verification.aspx

Let's not compare hashes in a way that creates cryptographic side-channels.

avatar sarciszewski sarciszewski - open - 25 Jun 2014
avatar sarciszewski sarciszewski - change - 25 Jun 2014
Labels Added: ? ?
avatar sarciszewski
sarciszewski - comment - 25 Jun 2014

One of the Travis builds failed not due to a code change. Not sure how to get it to retry...

avatar Bakual
Bakual - comment - 25 Jun 2014

Just do a commit, squash the existing ones or rebase the PR and it will do a new test. Basically just push something to update your branch.

Please also add testing instructions and be a bit more descriptive about what you want to do here and what it affects.
Don't assume others have the same knowledge about the code you have.

avatar sarciszewski
sarciszewski - comment - 25 Jun 2014

Good idea.

avatar sarciszewski sarciszewski - change - 25 Jun 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-06-25 22:10:14
avatar sarciszewski sarciszewski - close - 25 Jun 2014

Add a Comment

Login with GitHub to post a comment