? ? Pending

User tests: Successful: Unsuccessful:

avatar GHSVS-de
GHSVS-de
15 Jul 2022

Summary of Changes

Changed field types text to textarea:

  • restrict_uploads_extensions
  • image_extensions
  • audio_extensions
  • video_extensions
  • doc_extensions
  • ignore_extensions
  • upload_mime
  • upload_mime_illegal

Checked that array_map('trim', explode()) is used consistently at all relevant code points and adapted the code if not. To clarify that step: Joomla core uses array_map('trim', explode()) nearly at all code points when reading these parameters. I took it over where not.

I haven't included field upload_mime_illegal because I couldn't find any usage in core (#38280).

Testing Instructions

  • Go to mediamanager component > Options.
  • Change configuration options.
  • Test uploads if settings are respected.
  • & code review.

BEFORE applying this Pull Request

See that some fields are really hard to configure if you use higher window zoom and/or smaller devices:

image

image

Expected result AFTER applying this Pull Request

Nothing changed but the UI view.

image

image

  • Easier to read and configure.
  • Even spaces and/or newlines are possible because of consistent usage of array_map('trim', explode()) in core now.

Change some configuration settings and test if uploads still work like configured even if you add spaces or newlines after commas in textarea. Commas as separators are still mandatory as before!

avatar GHSVS-de GHSVS-de - open - 15 Jul 2022
avatar GHSVS-de GHSVS-de - change - 15 Jul 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Jul 2022
Category Administration com_media
avatar GHSVS-de GHSVS-de - change - 15 Jul 2022
The description was changed
avatar GHSVS-de GHSVS-de - edited - 15 Jul 2022
avatar GHSVS-de GHSVS-de - change - 15 Jul 2022
The description was changed
avatar GHSVS-de GHSVS-de - edited - 15 Jul 2022
avatar GHSVS-de GHSVS-de - change - 15 Jul 2022
The description was changed
avatar GHSVS-de GHSVS-de - edited - 15 Jul 2022
avatar GHSVS-de GHSVS-de - change - 15 Jul 2022
The description was changed
avatar GHSVS-de GHSVS-de - edited - 15 Jul 2022
avatar GHSVS-de GHSVS-de - change - 15 Jul 2022
Title
[4.2] com_media configuration view. Text fields to textarea.
[4.2] com_media (Mediamanager) configuration view. Text fields to textarea.
avatar GHSVS-de GHSVS-de - edited - 15 Jul 2022
avatar ChristineWk
ChristineWk - comment - 15 Jul 2022

I have tested this item successfully on 5373646


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38281.

avatar ChristineWk ChristineWk - test_item - 15 Jul 2022 - Tested successfully
avatar GHSVS-de GHSVS-de - change - 15 Jul 2022
The description was changed
avatar GHSVS-de GHSVS-de - edited - 15 Jul 2022
avatar GHSVS-de GHSVS-de - change - 15 Jul 2022
The description was changed
avatar GHSVS-de GHSVS-de - edited - 15 Jul 2022
avatar GHSVS-de GHSVS-de - change - 15 Jul 2022
Labels Added: ?
avatar viocassel
viocassel - comment - 17 Jul 2022

I have tested this item successfully on 5d534b9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38281.

avatar viocassel viocassel - test_item - 17 Jul 2022 - Tested successfully
avatar richard67 richard67 - change - 17 Jul 2022
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 17 Jul 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38281.

avatar richard67 richard67 - alter_testresult - 17 Jul 2022 - ChristineWk: Tested successfully
avatar roland-d roland-d - change - 1 Aug 2022
Labels Added: ?
avatar roland-d roland-d - close - 1 Aug 2022
avatar roland-d roland-d - merge - 1 Aug 2022
avatar roland-d roland-d - change - 1 Aug 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-08-01 08:01:22
Closed_By roland-d
avatar roland-d
roland-d - comment - 1 Aug 2022

Thank you

Add a Comment

Login with GitHub to post a comment