[#38255] - Remove label from a hidden field
- Fixed in Code Base
- 12 Jul 2022
- Medium
- Build: 4.2-dev
- # 38255
- Diff
- chmst:categories-label-assetid
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
See title. There are no labels for hidden fields asset_id in the whole system except here.
Testing Instructions
Code review.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_categories |
In my understanding hidden fields should not be accessible or announced.
Sorry I was confusing with something else
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38255.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38255.
Shouldn't the language string be marked with a deprecated comment in the 2 language files "administrator/language/en-GB/joomla.ini" and "api/language/en-GB/joomla.ini" because it is not used anymore when this PR is applied?
If I understand this correctly, the Key is already deprecated https://github.com/joomla/joomla-cms/blob/4.2-dev/administrator/language/en-GB/joomla.ini#L210
| Labels |
Added:
?
|
||
| Category | Administration com_categories | ⇒ | Administration com_categories Language & Strings |
Thanks - a misunderstanding
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38255.
| Labels |
Added:
?
Language Change
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-07-12 13:45:24 |
| Closed_By | ⇒ | roland-d |
Thank you
this is the correct one. the rest all result in accessibility errors