Feature ? Language Change PBF Maintainers Checked PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
4 Jul 2022

Summary of Changes

Logs fields in the user action logs

Testing Instructions

clean install of this branch or apply pr and run update sql
create a field
edit a field
check the two actions are in the user action log

Actual result BEFORE applying this Pull Request

nothing is displayed in the users action log component

Expected result AFTER applying this Pull Request

Entries displayed with clickable links

if nothing is displayed then open the actionlogs options and check to see if fields is in the list of loggable extensions and if not then add it.

Documentation Changes Required

none

ff1fd06 4 Jul 2022 avatar brianteeman sql
avatar brianteeman brianteeman - open - 4 Jul 2022
avatar brianteeman brianteeman - change - 4 Jul 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Jul 2022
Category Administration SQL com_admin Postgresql Language & Strings Installation
avatar viocassel viocassel - test_item - 4 Jul 2022 - Tested successfully
avatar viocassel
viocassel - comment - 4 Jul 2022

I have tested this item successfully on ff1fd06


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38221.

?

avatar Quy
Quy - comment - 4 Jul 2022

Add to as it is not enabled by default?

(0, 'com_actionlogs', 'component', 'com_actionlogs', '', 1, 1, 1, 0, 1, '', '{"ip_logging":0,"csv_delimiter":",","loggable_extensions":["com_banners","com_cache","com_categories","com_checkin","com_config","com_contact","com_content","com_installer","com_media","com_menus","com_messages","com_modules","com_newsfeeds","com_plugins","com_redirect","com_scheduler","com_tags","com_templates","com_users"]}', ''),

avatar brianteeman brianteeman - change - 5 Jul 2022
Labels Added: Language Change ? Maintainers Checked
avatar brianteeman
brianteeman - comment - 5 Jul 2022

Add to as it is not enabled by default?

Thanks - thought I had done that but obv didnt

avatar chmst
chmst - comment - 6 Jul 2022

Tested this in a fresh installation (no update).

It works for fields, but not for field groups. Is this correct?
grafik

And a linguistic question. For a German this looks strange: User xx performed a check in to table #__nn

avatar Quy
Quy - comment - 6 Jul 2022

Clicking on the field link goes to the last Field section visited. In the screenshot, it is an Article field yet it displays it as a User field.

38221

avatar brianteeman
brianteeman - comment - 6 Jul 2022

It works for fields, but not for field groups. Is this correct?

Yes - field groups is becond the scope of this pr. I would welcome someone adding support for that. (in other words I failed to achieve it)

And a linguistic question. For a German this looks strange: User xx performed a check in to table #__nn

I hope this helps you to understand https://developer.joomla.org/en-gb-user-interface-text-guidelines/action-or-description.html

avatar brianteeman
brianteeman - comment - 6 Jul 2022

Clicking on the field link goes to the last Field section visited. In the screenshot, it is an Article field yet it displays it as a User field.

grrhh - no idea how to address that

avatar chmst
chmst - comment - 6 Jul 2022

Thanks. I would say "I performed a check on a table " not in to a table, but can live with this ;)

The headline - yes. It probably comes from the context.

avatar brianteeman
brianteeman - comment - 6 Jul 2022

Thanks. I would say "I performed a check on a table " not in to a table, but can live with this ;)

No - it is specifically a check in

avatar chmst
chmst - comment - 6 Jul 2022

@Quy i have an article field. The context correct and the link is /administrator/index.php?option=com_fields&view=field&layout=edit&id=1&context=com_content.article goes to an article field.

grafik

avatar Quy
Quy - comment - 6 Jul 2022

@chmst Now create a User field. Then click on the Article field in the User Action Log. The heading will display it as a User field.

avatar chmst
chmst - comment - 6 Jul 2022

@Quy indeed. Seems to depend on the context in the user state.

avatar HLeithner
HLeithner - comment - 2 May 2023

This pull request has been automatically rebased to 5.0-dev.

avatar MacJoom MacJoom - change - 26 Aug 2023
Labels Added: Feature PBF PR-5.0-dev
Removed: ?
avatar richard67
richard67 - comment - 26 Aug 2023

@brianteeman Due to the rebase to 5.0-dev it needs to rename the update SQL scripts. I suggest to rename them to "5.0.0-2023-08-28.sql" because there are other PR's proposed which will already use "5.0.0-2023-08-22.sql" to "5.0.0-2023-08-27.sql". The base name needs to be greater than the one of the greatest update SQL script in the branch, using version_compare, otherwise it will not run on update when updating from a previous 5.0.0-alpha.

avatar brianteeman
brianteeman - comment - 26 Aug 2023

Feel free to do it. I don't use my pc on Sabbath

avatar MacJoom MacJoom - test_item - 26 Aug 2023 - Tested successfully
avatar MacJoom
MacJoom - comment - 26 Aug 2023

I have tested this item ✅ successfully on b917bc5

5.0.0-beta1-dev+pr.29376


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38221.

avatar richard67
richard67 - comment - 26 Aug 2023

Feel free to do it. I don't use my pc on Sabbath

@brianteeman Done.

@MacJoom It seems you have tested with a new installation. Could you also test with updating from a previous 5.0.0-alpha or from 4.4? Thanks in advance.

avatar MacJoom
MacJoom - comment - 26 Aug 2023

Works as a Update from 4.4.0 to 5.0 too. You have to add 'Fields' in the com_actionlogs options (Events to log), as stated in the instructions

avatar richard67 richard67 - alter_testresult - 26 Aug 2023 - MacJoom: Tested successfully
avatar richard67
richard67 - comment - 26 Aug 2023

@MacJoom Ok, I've restored your test result. Counter was reset after I've renamed the update SQL scripts. Do you think @viocassel 's test result still counts, too? He had tested before the PR was rebased, but after that there haven't been made any changes besides my scripts rename. Not sure if I shall count it and set the PR RTC or if a 2nd actual test would be better. What do you think?

avatar MacJoom
MacJoom - comment - 26 Aug 2023

@MacJoom Ok, I've restored your test result. Counter was reset after I've renamed the update SQL scripts. Do you think @viocassel 's test result still counts, too? He had tested before the PR was rebased, but after that there haven't been made any changes besides my scripts rename. Not sure if I shall count it and set the PR RTC or if a 2nd actual test would be better. What do you think?

I would prefer another test on 5.0 - his test is over a year old

avatar TLWebdesign TLWebdesign - test_item - 26 Aug 2023 - Tested successfully
avatar TLWebdesign
TLWebdesign - comment - 26 Aug 2023

I have tested this item ✅ successfully on 8877476

PBF23 ‎5.0.0-beta1-dev PHP 8.1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38221.

avatar richard67 richard67 - change - 26 Aug 2023
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 26 Aug 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38221.

avatar brianteeman brianteeman - change - 8 Sep 2023
Labels Added: ?
avatar brianteeman brianteeman - change - 8 Sep 2023
Title
[4.2] actionlogs for custom fields
[5.0] actionlogs for custom fields
avatar brianteeman brianteeman - edited - 8 Sep 2023
avatar HLeithner HLeithner - change - 12 Sep 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-12 18:09:44
Closed_By HLeithner
avatar HLeithner HLeithner - close - 12 Sep 2023
avatar HLeithner HLeithner - merge - 12 Sep 2023
avatar HLeithner
HLeithner - comment - 12 Sep 2023

Seems I missed this thanks

Add a Comment

Login with GitHub to post a comment