? Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar Kostelano
Kostelano
2 Jul 2022

Pull Request for Issue # .

Summary of Changes

  1. Fix showon="mfaredirectonlogin:1" for Onboard new users / Custom redirection URL parameters.
  2. In the database, I accidentally noticed that the new MFA uses the old language constant, and even from the frontend. Replaced with the correct string.

Screenshot_1

  1. Replaced COM_USERS_HEADING_MFA with COM_USERS_USER_MULTIFACTOR_AUTH, because the first key is also the heading in the users table. For many languages, it makes sense to reduce it to MFA, so as not to inflate an already large table. However, the same key was used on the authentication page when logging in - the short MFA is inappropriate there, the full name is needed.
  2. Language string PLG_MULTIFACTORAUTH_EMAIL_MAIL_LBL="Joomla: Authentication Code by Email" was never used.
  3. For 2 methods, the 'placeholder' elements were missing when authenticating on the site (after setting up the methods).
avatar Kostelano Kostelano - open - 2 Jul 2022
avatar Kostelano Kostelano - change - 2 Jul 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Jul 2022
Category Administration com_users Language & Strings Front End Plugins
avatar Kostelano Kostelano - change - 3 Jul 2022
Labels Added: Language Change ?
avatar laoneo
laoneo - comment - 3 Jul 2022

@nikosdion can you have a look here?

avatar joomla-cms-bot joomla-cms-bot - change - 3 Jul 2022
Category Administration com_users Language & Strings Front End Plugins Administration com_users Language & Strings
avatar Kostelano Kostelano - change - 13 Jul 2022
The description was changed
avatar Kostelano Kostelano - edited - 13 Jul 2022
avatar heelc29
heelc29 - comment - 21 Jul 2022

@Kostelano Could you please also correct the lang key in the description here:

COM_USERS_CONFIG_FRONTEND_SHOW_TITLE_DESC="Should I display a title in the frontend Multi-factor Authentication verification page? Please note that the title is always displayed in the backend. If you need to change the title please override the language key <code>COM_USERS_HEADING_MFA</code> using the System, Manage, Language Overrides page of the site's backend."

image

avatar Kostelano
Kostelano - comment - 22 Jul 2022

@heelc29 Thanks, corrected.

Also fixed the display of the NONE position for modules - the line is duplicated.

This can happen when you install a large package of extensions, but it is not at all the fact that you will use all the modules, say. In this case, they will be in the NONE position. This can confuse users.

Screenshot_1

At this point I have everything for this PR. Please test.

avatar heelc29
heelc29 - comment - 22 Jul 2022

I have tested this item successfully on 3ecd7cf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38208.

avatar heelc29 heelc29 - test_item - 22 Jul 2022 - Tested successfully
avatar viocassel
viocassel - comment - 22 Jul 2022

I have tested this item successfully on 3ecd7cf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38208.

avatar viocassel viocassel - test_item - 22 Jul 2022 - Tested successfully
avatar Quy Quy - change - 22 Jul 2022
Status Pending Ready to Commit
avatar Quy
Quy - comment - 22 Jul 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38208.

avatar Kostelano Kostelano - change - 4 Aug 2022
Labels Added: ?
avatar fancyFranci fancyFranci - close - 7 Sep 2022
avatar fancyFranci fancyFranci - merge - 7 Sep 2022
avatar fancyFranci fancyFranci - change - 7 Sep 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-09-07 11:54:52
Closed_By fancyFranci
avatar fancyFranci
fancyFranci - comment - 7 Sep 2022

Thanks a lot for your work!

Add a Comment

Login with GitHub to post a comment