? No Code Attached Yet ?
avatar sofianhit
sofianhit
2 Jul 2022

hi
in the header there are 4 divs
all of them have the "grid-child" class but the topbar dont has it .
so the module on topbar flaot to left because the "grid-child" class has a margin-left .
is this intentionally not has this class ?
can i know why it not has it !

screen shot 2022-07-02 at 19 41 03

avatar sofianhit sofianhit - open - 2 Jul 2022
avatar sofianhit sofianhit - change - 2 Jul 2022
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 2 Jul 2022
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 2 Jul 2022
avatar chmst
chmst - comment - 3 Jul 2022

Because another contributor wanted to have it like this and made a Pull Request.

@sofianhit You are workig on a site with an own design. So have lots of people and everyone has other needs and wishes. Do you know the concept of child templates? In a child templateof cassiopeia you can override everything, even the index.php.
#38204 (comment)

avatar richard67
richard67 - comment - 3 Jul 2022

The topbar position has been added with PR #31731 . Maybe when you read that PR and the comments on it you will find the explanation why it has been done like it has been done.

avatar sofianhit
sofianhit - comment - 3 Jul 2022

my question was not why added topbar position .
my question is why it is not has "grid-child" class .
I don't object the topbar itself , never , i like it, but module on it float to left .
i just speak about style it .

but i want to tell you :
the header need some works and improvement .
for example :
the topbar need another div inside it .
like this :

countModules('topbar')) : ?>
		<div class="container-topbar ">
			**<div class=" grid-child">**
		<jdoc:include type="modules" name="topbar" style="none" />
		**</div>**
			</div>
	<?php endif; ?>

the topbar will be 100% width and the inside div will get the grid-child class to be Collimated with the logo and below top modules .

i promise i will not ask any questions .
i will not request any features .
i will use what i get from joomla .

my problem is that i dont know php .

thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38206.
avatar sofianhit
sofianhit - comment - 3 Jul 2022
countModules('topbar')) : ?>
		<div class="container-topbar ">
			**<div class=" grid-child">**
		<jdoc:include type="modules" name="topbar" style="none" />
		**</div>**
			</div>
	<?php endif; ?>

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38206.
avatar chmst chmst - change - 3 Jul 2022
Labels Added: ? ?
avatar chmst chmst - labeled - 3 Jul 2022
avatar chmst chmst - labeled - 3 Jul 2022
avatar chmst
chmst - comment - 3 Jul 2022

Now as you have found the solution :) make a child template from casssiopeia and override the index.php. As you see, no php skills are required, it is only Html.
But I have labelled your request.

avatar brianteeman
brianteeman - comment - 8 Jul 2022

I dont see how this can be changed in core as it would change the behaviur on all existing sites uwing this position.

Should be closed.

avatar sofianhit
sofianhit - comment - 8 Jul 2022

close close , close all my posts . dont wait

avatar sofianhit
sofianhit - comment - 8 Jul 2022

I dont see how this can be changed in core as it would change the behaviur on all existing sites uwing this position.

Should be closed.

you comment without reading , you dont understand what wrote above .

avatar chmst chmst - close - 8 Jul 2022
avatar chmst
chmst - comment - 8 Jul 2022

Closing as requested

avatar chmst chmst - change - 8 Jul 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-07-08 09:43:32
Closed_By chmst

Add a Comment

Login with GitHub to post a comment