? Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
22 Jun 2014

Tracker

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33869&start=0

How to test

  1. enable debug
  2. make sure that the debug css is load if debug is on for all templates.
avatar zero-24 zero-24 - open - 22 Jun 2014
avatar zero-24 zero-24 - change - 22 Jun 2014
Title
[imp] Improve the "Is debug" check for the templates
[#33869] [imp] Improve the "Is debug" check for the templates
avatar sanderpotjer
sanderpotjer - comment - 11 Jul 2014

@test unsuccesful

The debug.css is already loading for all templates before applying the patch. Patch seems more code-styling changes rather then a fix.

Maybe @zero-24 can provide better test instructions?

avatar zero-24
zero-24 - comment - 14 Jul 2014

@sanderpotjer

Patch seems more code-styling changes rather then a fix.

Sure :smiley:
But after the change it is easier and smaler code. Sure it is more a "code style" PR (make our code more easy to understand and maintain) but it change the code so it need testing.

But as you note. Nothing is broken bevor or after the PR.

avatar Kubik-Rubik
Kubik-Rubik - comment - 27 Jul 2014

@zero-24 Okay, it's okay, you just moved the varible. Thank you!

avatar Bakual
Bakual - comment - 7 Aug 2014

@zero-24 Do you mind rebasing your PR to solve the conflicts? Thanks.

avatar zero-24 zero-24 - close - 8 Aug 2014
avatar zero-24
zero-24 - comment - 8 Aug 2014

@Bakual see here: #4086

avatar zero-24 zero-24 - change - 8 Aug 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-08-08 15:27:51
avatar zero-24 zero-24 - close - 8 Aug 2014
avatar zero-24 zero-24 - head_ref_deleted - 8 Aug 2014

Add a Comment

Login with GitHub to post a comment