? ? Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
30 Jun 2022

Summary of Changes

Code style for changes in #37910

Testing Instructions

Code review

5339da7 30 Jun 2022 avatar heelc29 cs
avatar heelc29 heelc29 - open - 30 Jun 2022
avatar heelc29 heelc29 - change - 30 Jun 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Jun 2022
Category Front End Plugins
avatar heelc29 heelc29 - change - 30 Jun 2022
Labels Added: ?
avatar richard67 richard67 - test_item - 30 Jun 2022 - Tested successfully
avatar richard67
richard67 - comment - 30 Jun 2022

I have tested this item successfully on a0054c2

Ok by review, and code style checks still succeed in drone.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38191.

avatar Quy Quy - test_item - 30 Jun 2022 - Tested successfully
avatar Quy
Quy - comment - 30 Jun 2022

I have tested this item successfully on a0054c2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38191.

avatar Quy Quy - change - 30 Jun 2022
Status Pending Ready to Commit
avatar Quy
Quy - comment - 30 Jun 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38191.

avatar richard67
richard67 - comment - 30 Jun 2022

@HLeithner Any idea why PHPCS doesn't complain about the code style in that file without this PR?

avatar richard67 richard67 - change - 30 Jun 2022
Labels Added: ?
avatar richard67 richard67 - alter_testresult - 30 Jun 2022 - richard67: Tested successfully
avatar richard67 richard67 - alter_testresult - 30 Jun 2022 - Quy: Tested successfully
avatar laoneo laoneo - change - 30 Jun 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-06-30 21:10:44
Closed_By laoneo
avatar laoneo laoneo - close - 30 Jun 2022
avatar laoneo laoneo - merge - 30 Jun 2022
avatar laoneo
laoneo - comment - 30 Jun 2022

Thanks!

Add a Comment

Login with GitHub to post a comment