[#38187] - Installer must implement the DB aware interface as well
- Fixed in Code Base
- 30 Jun 2022
- Medium
- Build: 4.2-dev
- # 38187
- Diff
- Digital-Peak:j4/installer/db-interface
User tests: Successful: Unsuccessful:
Pull Request for Issue #38173.
Summary of Changes
The Installer must also implement the DatabaseAwareInterface so the database is automatically populated in the Adapter class.
Testing Instructions
Install OSMap through the web installer.
Actual result BEFORE applying this Pull Request
A warning is displayed with the message that the database is not set.
Expected result AFTER applying this Pull Request
No error and the extension installs fine.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
Before
After
Looks like the trim message is unrelated as its present before and after and is code from the extension
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38187.
| Status | Pending | ⇒ | Ready to Commit |
rtc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38187.
| Labels |
Added:
?
Release Blocker
?
|
||
Thanks for the tests. Would be good if you guys can install some other extensions as well. I tried a couple ones and they worked. But acymailing didn't work for me, but there was the message that a manifest file couldn't be found, a bit similar to #38179 but it was a package upload. So not sure if this is an issue with my docker/dev setup or if there is a bigger issue.
acy is a big download so maybe thats your problem?
install from web worked for me
Tested all of our extensions (RSJoomla!), they now install, Acymailing installs but it's terribly slow, not sure what their code is doing during the install.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-06-30 16:09:23 |
| Closed_By | ⇒ | wilsonge |
Merging this as it's confirmed as resolving several extensions.
I have tested this item✅ successfully on 4005e76
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38187.