[#38180] - Allow to select the edit layout for subforms in custom fields
- Fixed in Code Base
- 28 Jan 2023
- Medium
- Build: 4.2-dev
- # 38180
- Diff
- HLeithner:feature/subform-editlayout
User tests: Successful: Unsuccessful:
Summary of Changes
Add a column to the subform custom field which allows to select they layout for editing
Testing Instructions
- create a subform
- select the type of the edit layout
- layout is used on editing
Actual result BEFORE applying this Pull Request
Not possible
Expected result AFTER applying this Pull Request
Works
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Front End Plugins |
This is a good example of issues with the editorconfig that we now have.
The file is using tabs but your new code is using spaces :(
hmm you are right, seems I was to optimistic for the editorconfig.
I will write a PR that only php files uses spaces.
| Labels |
Added:
Language Change
?
|
||
Now I used tabs in the xml
Works well, and is a need! Just would recommend moving the field to Options tab in the Form Options field group, as that pattern is already established in other field types like radio:
Hahaha my change made something not work. Sorry.
Since 4.2 only accepts Bugfixes and this is a new feature (or rather an improvement), I've rebased the PR to 4.3-dev and updated it.
| Labels |
Added:
PR-4.3-dev
|
||
| Labels |
Removed:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38180.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38180.
Documentation added
https://docs.joomla.org/Help4.x:Fields:_Edit
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38180.
| Labels |
Added:
?
|
||
Thanks @carlitorweb for the documentation update
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-01-28 12:38:17 |
| Closed_By | ⇒ | rdeutz |
This is a good example of issues with the editorconfig that we now have.
The file is using tabs but your new code is using spaces :(