[#38178] - Remove subform in subform limitation for custom fields
- Closed
- 6 Apr 2024
- Medium
- Build: 4.2-dev
- # 38178
- Diff
- HLeithner:feature/subform-subform
User tests: Successful: Unsuccessful:
Summary of Changes
Remove the limitation to select a subform as a subform field in custom fields.
There is no reason we have this limit, subforms can already be used as field of another subform.
Testing Instructions
- Create a number of custom fields
- Create a subform !1
- Add the fields to the subform
- Create a subform !2
- Add subform !1 to subform !2
- check if everything works
Actual result BEFORE applying this Pull Request
It's not possible to select subform !1 in subform !2
Expected result AFTER applying this Pull Request
You can select subform !1 in subform !2 and you also can edit it
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields |
a limit of zero - aka the current situation seems perfect to me
I think we need to consider a nesting limit to stop the UI from falling apart.
didn't looked at it yet but someone already came up with the question and I hope this protection is already in the field^^
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-06-29 14:58:54 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2022-06-29 14:58:54 | ⇒ | |
| Closed_By | HLeithner | ⇒ |
| Status | New | ⇒ | Pending |
I think that protection is the code your deleting ;)
I would be very happy to have this in core, personally.
This pull request has been automatically rebased to 4.3-dev.
This pull request has been automatically rebased to 4.4-dev.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-04-06 15:41:14 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
bug
Small
PR-4.4-dev
Removed: ? |
||
I think we need to consider a nesting limit to stop the UI from falling apart.