? ? Pending

User tests: Successful: Unsuccessful:

avatar HLeithner
HLeithner
27 Jun 2022

Summary of Changes

Add a script to rebase pull requests

Testing Instructions

Code review

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

Add to internal docu

avatar HLeithner HLeithner - open - 27 Jun 2022
avatar HLeithner HLeithner - change - 27 Jun 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Jun 2022
Category Repository
avatar HLeithner
HLeithner - comment - 27 Jun 2022

@brianteeman if you like to have a look at my english again. I used this script to rebase pull requests from 4.1-dev to 4.2-dev

avatar brianteeman
brianteeman - comment - 27 Jun 2022

Sorry only just saw this.

In addition to the inline comments what is clear from the results of running the script is that the comment in the pr needs some sort of additional message to show that the pr was created by a bot and not a human.

Also I assume that in the future this script and the psr12 script will be moved from your personal account to a dedicated bot account.

avatar HLeithner
HLeithner - comment - 27 Jun 2022

Sorry only just saw this.

In addition to the inline comments what is clear from the results of running the script is that the comment in the pr needs some sort of additional message to show that the pr was created by a bot and not a human.

Also I assume that in the future this script and the psr12 script will be moved from your personal account to a dedicated bot account.

The account is used of the user who executes it, so psr12 will be run by me and the rebase by the release lead. Using the bot account for this doesn't makes it easier for us....

avatar HLeithner
HLeithner - comment - 27 Jun 2022

but hmm for the psr-12 PR updates I can try to use the bot... I will check try this

avatar HLeithner HLeithner - change - 27 Jun 2022
Labels Added: ?
avatar brianteeman
brianteeman - comment - 27 Jun 2022

it should not be run from a personal account but from one that is dedicated to the purpose and owned by the project. Its bad practice to use a private account for this.

avatar joomla-bot
joomla-bot - comment - 27 Jun 2022

This pull requests has been automatically converted to the PSR-12 coding standard.

avatar HLeithner HLeithner - change - 27 Jun 2022
Labels Added: ?
avatar brianteeman
brianteeman - comment - 28 Jun 2022

LGTM

avatar HLeithner HLeithner - change - 28 Jun 2022
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-06-28 07:10:44
Closed_By HLeithner
avatar HLeithner HLeithner - close - 28 Jun 2022
avatar HLeithner HLeithner - merge - 28 Jun 2022

Add a Comment

Login with GitHub to post a comment