[#38149] - [5.0] order site/admin menus in admin ui
- Fixed in Code Base
- 17 Jul 2023
- Medium
- Build: 4.2-dev
- # 38149
- Diff
- brianteeman:menu_order
User tests: Successful: Unsuccessful:
The site and admin menus displayed in the admin interface sidebar are hard coded to be displayed by id desc
This PR allows the order to be changed using drag and drop from com_menus&view=menus
Pull Request for Issue #38143
When thinking about documentation for this PR I concluded that this is NOT a new feature but its more of a bug that you couldnt sort them before just as you can sort everything else.
To test
Clean install from the prebuilt package in this PR
Create multiple site and admin menus (they dont need any menu items in them for the prupose of this test)
Drag and drop to change the order
Refresh the page and you will see the changes take effect in the sidebar
Update an existing test site using the prebuilt package in this pr
Repeat the steps above.
thanks @HLeithner
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus |
| Labels |
Added:
?
?
|
||
This pull request has been automatically rebased to 5.0-dev.
@brianteeman would be great if you had time to finish this pr I would be happy to merge it into 5.0
If I knew how I would. That's why I asked for help
| Title |
|
||||||
oh sorry I didn't saw your comment, what exactly do you need? or is it the todo list you added where you need help?
| Labels |
Added:
Feature
PR-5.0-dev
Removed: ? ? |
||
| Category | Administration com_menus | ⇒ | SQL Administration com_admin Postgresql com_menus |
| Category | Administration com_menus SQL com_admin Postgresql | ⇒ | SQL Administration com_admin Postgresql com_menus Installation |
@HLeithner sorry - had to look at the code again to see where I had left it.
currently stuck at saveorderingajax
probably missing something obvious but I just cant see it
I updated the controller now it's working
shucks - i changed the controller but not the model.
will test it tomorrow and see what else needs doing
thanks
Maybe we should update the ordering column of the existing menu entries when adding the ordering column. Something like update #__menus set ordering=id
yes I was planning on doing that and also checking the sample data plugins
| Title |
|
||||||
The ordering of menu Items will be a challenge. First tests look very promising. Thanks for that @brianteeman
The ordering of menu Items will be a challenge.
Not sure what you mean. This PR is about ordering the menus not the items
Sorry, forget it. Multi-tasking-failure ;)
I have tested this item
Tested new install and tested by updating an instance. Really great, nice to have. Thanks, Brian. :)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38149.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-07-17 12:06:45 |
| Closed_By | ⇒ | HLeithner |
thanks
thanks
This pull requests has been automatically converted to the PSR-12 coding standard.