Feeling Lucky
?
?
[#38132] - [4.2] Fix fatal error on webauthn plugin
- Fixed in Code Base
- 26 Jun 2022
- Medium
- Build: 4.2-dev
- # 38132
- Diff
- joomdonation:fix_fatal_error_webauthn
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
PR #38060 removed $app property from the class, so using $this->app in the layout causes fatal error. We need to use $this->getApplication() to get application object instead.
I also removed an un-used use statement in the plugin layout code.
Testing Instructions
I don't have experience with using the plugin, so please ignore if my testing instructions are wrong
- Use Joomla 4.2 nightly build
- Make sure Multi-factor Authentication - Web Authentication plugin is enabled
- Login to administrator area of your site, edit an user account, look at Multi-factor Authentication tab, click on Add a new Web Authentication button.
Actual result BEFORE applying this Pull Request
Get fatal error: Call to a member function getDocument() on null
Expected result AFTER applying this Pull Request
Error is gone, the page loads OK
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
richard67
- comment
- 26 Jun 2022
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38132.
| Labels |
Added:
?
|
||
richard67
- comment
- 26 Jun 2022
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38132.
| Status | Pending | ⇒ | Ready to Commit |
richard67
- comment
- 26 Jun 2022
RTC !!!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38132.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-06-26 12:47:39 |
| Closed_By | ⇒ | laoneo |
laoneo
- comment
- 26 Jun 2022
Thanks!
I have tested this item✅ successfully on a5042e1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38132.