Feature PR-5.0-dev ? Pending

User tests: Successful: Unsuccessful:

avatar pritam825
pritam825
22 Jun 2022

It's Not an Issue, It's an suggestion

Summary of Changes

Testing Instructions

go to administrator->Banners->Banners->New

Actual result BEFORE applying this Pull Request

No Separate Section for SEO and Metadata section is in publishing section

Expected result AFTER applying this Pull Request

image

If this is ok for everyone then will create for others also.

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
4.00

avatar pritam825 pritam825 - open - 22 Jun 2022
avatar pritam825 pritam825 - change - 22 Jun 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Jun 2022
Category Administration com_banners
avatar pritam825 pritam825 - change - 22 Jun 2022
Labels Added: ?
avatar pritam825 pritam825 - change - 22 Jun 2022
The description was changed
avatar pritam825 pritam825 - edited - 22 Jun 2022
avatar pritam825 pritam825 - change - 22 Jun 2022
The description was changed
avatar pritam825 pritam825 - edited - 22 Jun 2022
avatar pritam825 pritam825 - change - 22 Jun 2022
The description was changed
avatar pritam825 pritam825 - edited - 22 Jun 2022
avatar pritam825 pritam825 - change - 22 Jun 2022
The description was changed
avatar pritam825 pritam825 - edited - 22 Jun 2022
avatar pritam825 pritam825 - change - 22 Jun 2022
Title
Added Separate Section
Added Separate Section For SEO
avatar pritam825 pritam825 - edited - 22 Jun 2022
avatar brianteeman
brianteeman - comment - 22 Jun 2022

None of those fields are anything to do with SEO

avatar pritam825
pritam825 - comment - 22 Jun 2022

None of those fields are anything to do with SEO

Metadata comes under seo

avatar brianteeman
brianteeman - comment - 22 Jun 2022

You should look at how the data is used. None of those fields are used for seo

avatar pritam825
pritam825 - comment - 22 Jun 2022

@brianteeman
image
so, according to you this should be in separate section because of meta description part?

avatar Quy
Quy - comment - 22 Jun 2022

See discussion #15833

avatar pritam825
pritam825 - comment - 22 Jun 2022

@Quy I have read the discussion but not seeing any end-up of discussion , some people says it's good , some not, if you all are ok with this then I will create pr for every component, otherwise I will close this, Thanks :)

avatar Quy
Quy - comment - 22 Jun 2022

I don't see the point of moving just 3 fields to its own tab especially if they are not updated often.
What is your rationale to justify its own tab?
Why not do a text override to "Publishing/SEO" in your installation?

avatar pritam825
pritam825 - comment - 23 Jun 2022

I don't see the point of moving just 3 fields to its own tab especially if they are not updated often. What is your rationale to justify its own tab? Why not do a text override to "Publishing/SEO" in your installation?

For example if I will have to add the meta description or keywords so first thing which comes in mind that there will be an separate SEO section where I can find the all functionality for SEO, how will I know that it will come under publishing

avatar Quy
Quy - comment - 23 Jun 2022

It may not be obvious at first, but once you know where these settings are under Publishing then I don't see the issue. Create a language override if you need a reminder.

avatar joomla-bot
joomla-bot - comment - 27 Jun 2022

This pull requests has been automatically converted to the PSR-12 coding standard.

avatar HLeithner HLeithner - change - 27 Jun 2022
Labels Added: ?
avatar HLeithner
HLeithner - comment - 2 May 2023

This pull request has been automatically rebased to 5.0-dev.

avatar web-eau-net web-eau-net - test_item - 26 Aug 2023 - Tested successfully
avatar web-eau-net
web-eau-net - comment - 26 Aug 2023

I have tested this item ✅ successfully on 1e8b03b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38124.

avatar Quy
Quy - comment - 4 Sep 2023

Thank you for the PR. Closing for now for reason stated. When there are additional SEO settings added, we will revisit this.

avatar Quy Quy - change - 4 Sep 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-09-04 16:07:39
Closed_By Quy
Labels Added: Feature PR-5.0-dev ?
Removed: ? ?
avatar Quy Quy - close - 4 Sep 2023

Add a Comment

Login with GitHub to post a comment