Ever since @richard67 introduced me to the 2-in-1 bug specials I only find this kind of bugs. This morning we will see that an update with <supported_databases> always results in an error and the error message is misleading.

Steps to reproduce the issue

• Install an older version of an extension with <supported_databases> in its XML update file, e.g. https://github.com/lucid-fox/social-magick/releases/download/1.0.1/socialmagick-1.0.1.zip
• Go to System, Update, Extensions
• Click on Check for Updates

Expected result

Update found, no warning.

Actual result

A bunch of misleading warnings:

• For the extension Social Magick version 1.0.2 is available, but your current database MySQL (PDO) is not supported anymore.
• For the extension Social Magick version 1.0.1 is available, but your current database MySQL (PDO) is not supported anymore.
• For the extension Social Magick version 1.0.0 is available, but your current database MySQL (PDO) is not supported anymore.

System information (as much as possible)

Joomla 4.1.5 on PHP 8.1 but this might be irrelevant as the issue seems to exist since #12355

Additional comments

They say a picture is worth one thousand words. I agree:

In libraries/src/Updater/Adapter/ExtensionAdapter.php:159 we are trying to see if the site's database connector object's $dbType (all lowercase) matches one of the keys of the $supportedDbs array. However, the keys in the $supportedDbs array are upppercase. Therefore we will never match a database type...

This is bug number one.

We then display the JLIB_INSTALLER_AVAILABLE_UPDATE_DB_MINIMUM message but instead of reporting the database server type (e.g. MySQL) we report the database connector name (e.g. MySQLi or PDO MySQL). This causes the asinine and misleading messages sampled above.

This is bug number two.

How to fix this

For the first bug change line 159 from

if (\array_key_exists($dbType, $supportedDbs))

to

if (in_array(strtolower($dbType), array_map('strtolower', array_keys($supportedDbs))))

For the second bug, change lines 167 to 174 from

								$dbMsg = Text::sprintf(
									'JLIB_INSTALLER_AVAILABLE_UPDATE_DB_MINIMUM',
									$this->currentUpdate->name,
									$this->currentUpdate->version,
									Text::_($db->name),
									$dbVersion,
									$minimumVersion
								);

to

								$dbMsg = Text::sprintf(
									'JLIB_INSTALLER_AVAILABLE_UPDATE_DB_MINIMUM',
									$this->currentUpdate->name,
									$this->currentUpdate->version,
									Text::_('JLIB_DB_SERVER_TYPE_' . $dbType),
									$dbVersion,
									$minimumVersion
								);

and create the lang strings JLIB_DB_SERVER_TYPE_MARIADB, JLIB_DB_SERVER_TYPE_MYSQL, JLIB_DB_SERVER_TYPE_POSTGRESQL, JLIB_DB_SERVER_TYPE_ORACLE, JLIB_DB_SERVER_TYPE_SQLITE, JLIB_DB_SERVER_TYPE_MSSQL which are far cleaner than the existing, unprefixed ones.

Credits

Hat tip to the ever keen-eyed @woluweb who noticed these warnings and reported them to a repository I help with.