Feeling Lucky
?
Language Change
?
Maintainers Checked
[#38113] - [4] install language - an error message when no xml is returned
- Fixed in Code Base
- 23 Jun 2022
- Medium
- Build: 4.2-dev
- # 38113
- Diff
- alikon:patch-5
User tests: Successful: Unsuccessful:
Pull Request for Issue #38110 .
Summary of Changes
added a check if the xml is returned
Testing Instructions
add a $response->body= ""; on line 153 to simulate the case
Actual result BEFORE applying this Pull Request
PHP Warning: Attempt to read property "extension" on bool in /shared/httpd/dev4/joomla-cms/administrator/components/com_installer/src/Model/LanguagesModel.php on line 158
Expected result AFTER applying this Pull Request
a proper error message
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer Language & Strings |
| Labels |
Added:
Language Change
?
Maintainers Checked
|
||
Quy
- comment
- 22 Jun 2022
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38113.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 22 Jun 2022
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38113.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-06-23 17:11:19 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 23 Jun 2022
Thanks!
I have tested this item✅ successfully on 6d0afcf
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38113.