NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
20 Jun 2022

Summary of Changes

CodeMirror updated to 5.65.6
and various dev dependencies

All scripts that are not dev dependencies have already been updated or are semver compatible

avatar brianteeman brianteeman - open - 20 Jun 2022
avatar brianteeman brianteeman - change - 20 Jun 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Jun 2022
Category NPM Change Front End Plugins
avatar brianteeman brianteeman - change - 20 Jun 2022
Labels Added: NPM Resource Changed ?
avatar brianteeman brianteeman - change - 20 Jun 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-06-20 16:24:04
Closed_By brianteeman
avatar brianteeman
brianteeman - comment - 20 Jun 2022

testing should be quite simple. Apply the pr. then npm ci

There should be no new files to commit

then run npm outdated and the output will be
image

avatar brianteeman brianteeman - close - 20 Jun 2022
avatar brianteeman brianteeman - change - 20 Jun 2022
Status Closed New
Closed_Date 2022-06-20 16:24:04
Closed_By brianteeman
avatar brianteeman brianteeman - change - 20 Jun 2022
Status New Pending
avatar brianteeman brianteeman - reopen - 20 Jun 2022
avatar laoneo
laoneo - comment - 20 Jun 2022

Vue should be updated as well as it is only a patch shift.

avatar brianteeman
brianteeman - comment - 20 Jun 2022

@laoneo thanks - vue was locked to a specific patch release. Its not any more

avatar laoneo
laoneo - comment - 20 Jun 2022

Then I'm wondering why it got locked. It was done in #36295. @dgrammatiko any reason you locked vue to a specific release?

avatar dgrammatiko
dgrammatiko - comment - 20 Jun 2022

@dgrammatiko any reason you locked vue to a specific release?

Yes, the reason is security and assuring that the person in charge of releases will NOT accidentally distribute a version that was not tested/peer reviewed/etc. FWIW for years I kept asking for an automated solution for both npm+composer but gloriously ignored. Anyways, both package.json and composer.json SHOULD point to specific versions for the dependencies (joomla is not a weekend project, so maintainers should treat it respectively).

An implementation of renovate bot in this repo will apply this before start doing any PRs for updating any of the dependencies (you can check it in one of my many repos where I use it for quite some time, eg: package.josn renovate.josn ).

avatar laoneo
laoneo - comment - 21 Jun 2022

The lock file does the job of pointing to a specific version. There is no need to do that in the config file as well, except when there is a bug/incompatibility/whatever in the library and we have to stick to a specific version.

avatar dgrammatiko
dgrammatiko - comment - 21 Jun 2022
avatar brianteeman
brianteeman - comment - 21 Jun 2022

if everybody was doing that then there would be zero point in the ^ or ~ functionality existing.

avatar brianteeman
brianteeman - comment - 23 Jun 2022

closed. i'm not wasting my time resolving conflicts

avatar brianteeman brianteeman - change - 23 Jun 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-06-23 15:33:30
Closed_By brianteeman
avatar brianteeman brianteeman - close - 23 Jun 2022

Add a Comment

Login with GitHub to post a comment