? Success

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
20 Jun 2014

Scope:
Add the ability to encode 64 the flag images on mod_languages.

Why: Reduce the http requests per page...

How to test: Install a multilingual Joomla! with some dummy content. Enable the mod_languages module (Language Switcher). Check the options, play with encode. Everything should still work. Report bugs

avatar dgt41 dgt41 - open - 20 Jun 2014
avatar dgt41
dgt41 - comment - 20 Jun 2014

Bonus: You can create an override on the html/mod_languages/ and set the pre encoded data there (on the languages you have set), reducing the load on the server side:

Use this site to get the encoded data: http://webcodertools.com/imagetobase64converter
replace the languages to those that you use :)

avatar dgt41 dgt41 - change - 20 Jun 2014
Labels Added: ? ?
avatar Bakual
Bakual - comment - 20 Jun 2014

Current behavior using JHtml::image() will search for an image override in the template. Your approach will no longer allow this.
To use a different image, you'd have to override the whole module output.

avatar dgt41
dgt41 - comment - 20 Jun 2014

@Bakual: You are right that's BC. We should respect the flag images overrides... Code updated!

avatar Bakual
Bakual - comment - 20 Jun 2014

Bonus: You can create an override on the html/mod_languages/ and set the pre encoded data there (on the languages you have set), reducing the load on the server side:

You can of course also do that without your PR. Just saying :smile:

avatar brianteeman brianteeman - change - 21 Aug 2014
Status New Pending
avatar nicksavov nicksavov - change - 21 Aug 2014
Labels Removed: ?
avatar brianteeman brianteeman - change - 1 Sep 2014
Category Modules Multilanguage
avatar dgt41 dgt41 - close - 7 Nov 2014
avatar dgt41 dgt41 - close - 7 Nov 2014
avatar dgt41 dgt41 - change - 7 Nov 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-11-07 22:06:41
avatar dgt41 dgt41 - head_ref_deleted - 8 Nov 2014

Add a Comment

Login with GitHub to post a comment