Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#38072] - [4.2] Convert the checkfiles plugin to service provider

? ? ? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
16 Jun 2022

Summary of Changes

Converts the checkfiles plugin to service provider and adds some unit tests. This pr is based on #38060, so please test that one first.

Testing Instructions

  • Create a folder in images with the name test and upload there a big image from unsplash or so which is bigger than 1080 pixels
  • Go to the task scheduler back end list
  • Click on new "Image Size Check"
  • Select the test image in the task parameters
  • Save the task and close the form
  • Run the task by clicking on "Run Test" button

Actual result BEFORE applying this Pull Request

The image in the test folder has a width or height of 1080 pixels.

Expected result AFTER applying this Pull Request

The image in the test folder has a width or height of 1080 pixels.

avatar laoneo laoneo - open - 16 Jun 2022
avatar laoneo laoneo - change - 16 Jun 2022
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jun 2022
Category ⇒ Administration Libraries Front End Plugins Unit Tests
avatar laoneo laoneo - change - 18 Jun 2022
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 18 Jun 2022
Category Administration Libraries Front End Plugins Unit Tests ⇒ Front End Plugins Unit Tests
avatar alikon alikon - test_item - 22 Jun 2022 - Tested successfully
avatar alikon
alikon - comment - 22 Jun 2022

I have tested this item ✅ successfully on db97381

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38072.

avatar joomla-bot
joomla-bot - comment - 27 Jun 2022

A new pull request has been created automatically to convert this PR to the PSR-12 coding standard. The pr can be found at Digital-Peak#24

avatar HLeithner
HLeithner - comment - 27 Jun 2022

A new pull request has been created automatically to convert this PR to the PSR-12 coding standard. The pr can be found at Digital-Peak#24

there was a merge error on this pull request please check if worked correctly

avatar laoneo laoneo - change - 28 Jun 2022
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jun 2022
Category Front End Plugins Unit Tests ⇒ Unit Tests Administration com_admin
avatar laoneo laoneo - change - 28 Jun 2022
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2022-06-28 05:41:17
Closed_By ⇒ laoneo
avatar laoneo laoneo - close - 28 Jun 2022
avatar laoneo laoneo - close - 28 Jun 2022
avatar laoneo laoneo - change - 28 Jun 2022
Status Closed ⇒ New
Closed_Date 2022-06-28 05:41:17 ⇒
Closed_By laoneo ⇒
avatar laoneo laoneo - change - 28 Jun 2022
Status New ⇒ Pending
avatar laoneo laoneo - reopen - 28 Jun 2022
avatar laoneo laoneo - change - 28 Jun 2022
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2022-06-28 05:46:39
Closed_By ⇒ laoneo
avatar laoneo laoneo - change - 28 Jun 2022
Status Closed ⇒ Pending
avatar laoneo laoneo - close - 28 Jun 2022
avatar laoneo laoneo - close - 28 Jun 2022
ffc9a67 28 Jun 2022 avatar laoneo redo
avatar laoneo laoneo - reopen - 28 Jun 2022
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jun 2022
Category Unit Tests Administration com_admin ⇒ Front End Plugins Unit Tests
avatar laoneo
laoneo - comment - 28 Jun 2022

I had to redo this pr, @heelc29 can you have a look again if I missed something. Thanks!

avatar laoneo
laoneo - comment - 29 Jun 2022

I know, somehow the psr change screwed up this pr and I had to redo it from an old stage. Sorry for that and thanks for your help.

2feadf2 3 Jul 2022 avatar laoneo cs
avatar roland-d roland-d - close - 3 Jul 2022
avatar roland-d roland-d - merge - 3 Jul 2022
avatar roland-d roland-d - change - 3 Jul 2022
Status Pending ⇒ Fixed in Code Base
Closed_Date 2022-06-28 05:46:39 ⇒ 2022-07-03 12:01:27
Closed_By laoneo ⇒ roland-d
avatar roland-d
roland-d - comment - 3 Jul 2022

Thank you

Add a Comment

Login with GitHub to post a comment