? ? Pending

User tests: Successful: Unsuccessful:

avatar korenevskiy
korenevskiy
15 Jun 2022

Pull Request for Issue # .

Summary of Changes

Adds ID control for tables.
A new fix fixes the error.
Now you can use this method several times on one page for several tables.

Testing Instructions

If you place 2 lists/tables on one page, and for each table indicate

<body>
	<table><tbody class='js-draggable'> .... <tbody></table>
	<ul class='js-draggable'> .... </ul>
	<div class='js-draggable'> .... </div>
</body>
JHtml::_('draggablelist.draggable') ;

That code will only work 1 time for the first call.
My correction will allow you to place dragable lists, tables repeatedly on one page.

Actual result BEFORE applying this Pull Request

That code will only work 1 time for the first call.

Expected result AFTER applying this Pull Request

Now the dragable lists/tables will work on one page for each table.

draggable.JS.zip /media/system/js/draggable.js

It is also required to add a loop to sort out all the tables on the page in the draggable.JS file .

They are here in the archive.
But I don’t know which repository to do this.

avatar korenevskiy korenevskiy - open - 15 Jun 2022
avatar korenevskiy korenevskiy - change - 15 Jun 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Jun 2022
Category Libraries
avatar korenevskiy korenevskiy - change - 15 Jun 2022
Labels Added: ?
avatar korenevskiy korenevskiy - change - 15 Jun 2022
The description was changed
avatar korenevskiy korenevskiy - edited - 15 Jun 2022
avatar korenevskiy korenevskiy - change - 15 Jun 2022
The description was changed
avatar korenevskiy korenevskiy - edited - 15 Jun 2022
avatar korenevskiy korenevskiy - change - 15 Jun 2022
The description was changed
avatar korenevskiy korenevskiy - edited - 15 Jun 2022
avatar korenevskiy korenevskiy - change - 15 Jun 2022
The description was changed
avatar korenevskiy korenevskiy - edited - 15 Jun 2022
avatar korenevskiy korenevskiy - change - 15 Jun 2022
The description was changed
avatar korenevskiy korenevskiy - edited - 15 Jun 2022
avatar korenevskiy korenevskiy - change - 15 Jun 2022
The description was changed
avatar korenevskiy korenevskiy - edited - 15 Jun 2022
avatar korenevskiy korenevskiy - change - 15 Jun 2022
The description was changed
avatar korenevskiy korenevskiy - edited - 15 Jun 2022
avatar korenevskiy korenevskiy - change - 15 Jun 2022
The description was changed
avatar korenevskiy korenevskiy - edited - 15 Jun 2022
avatar korenevskiy korenevskiy - change - 15 Jun 2022
Title
Fix drag and drop for multiple tables/ul's/lists entries on one page - DraggableList.php
Fix drag and drop for multiple tables/ul's/ol's/lists entries on one page - DraggableList.php
avatar korenevskiy korenevskiy - edited - 15 Jun 2022
avatar korenevskiy korenevskiy - change - 15 Jun 2022
The description was changed
avatar korenevskiy korenevskiy - edited - 15 Jun 2022
avatar korenevskiy korenevskiy - change - 15 Jun 2022
The description was changed
avatar korenevskiy korenevskiy - edited - 15 Jun 2022
avatar korenevskiy korenevskiy - change - 15 Jun 2022
The description was changed
avatar korenevskiy korenevskiy - edited - 15 Jun 2022
avatar korenevskiy korenevskiy - change - 15 Jun 2022
The description was changed
avatar korenevskiy korenevskiy - edited - 15 Jun 2022
avatar korenevskiy korenevskiy - change - 15 Jun 2022
The description was changed
avatar korenevskiy korenevskiy - edited - 15 Jun 2022
avatar korenevskiy korenevskiy - change - 15 Jun 2022
The description was changed
avatar korenevskiy korenevskiy - edited - 15 Jun 2022
avatar laoneo
laoneo - comment - 16 Jun 2022

Can you please extend your testing instructions where this code can be added in a core file so a tester can check the result.

avatar HLeithner
HLeithner - comment - 27 Jun 2022

This pull requests has automatically rebased to 4.2-dev.

avatar joomla-bot
joomla-bot - comment - 27 Jun 2022

This pull requests has been automatically converted to the PSR-12 coding standard.

avatar HLeithner HLeithner - change - 27 Jun 2022
Labels Added: ?
avatar korenevskiy korenevskiy - change - 1 Jul 2022
Labels Added: ?
Removed: ?
avatar HLeithner
HLeithner - comment - 2 May 2023

This pull request has been automatically rebased to 4.3-dev.

avatar korenevskiy
korenevskiy - comment - 3 May 2023

Can you please extend your testing instructions where this code can be added in a core file so a tester can check the result.

Tell me how you can translate the status of this PR into a draft or disable it. This PR is not completed, there is an error, but it has not been resolved. This PR is 60-70% complete.

avatar alikon
alikon - comment - 3 May 2023

for change the status to draft --- click on convert to draft on the left side of your pr
image

avatar HLeithner
HLeithner - comment - 30 Sep 2023

This pull request has been automatically rebased to 4.4-dev.

avatar HLeithner HLeithner - change - 24 Apr 2024
Title
Fix drag and drop for multiple tables/ul's/ol's/lists entries on one page - DraggableList.php
[4.4] Fix drag and drop for multiple tables/ul's/ol's/lists entries on one page - DraggableList.php
avatar HLeithner HLeithner - edited - 24 Apr 2024

Add a Comment

Login with GitHub to post a comment