[#38070] - [5.2] Fix drag and drop for multiple tables/ul's/ol's/lists entries on one page - DraggableList.php
- Pending
- Medium
- Build: 4.1-dev
- # 38070
- Diff
- korenevskiy:JHtml_("DraggableListdraggable")
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Adds ID control for tables.
A new fix fixes the error.
Now you can use this method several times on one page for several tables.
Testing Instructions
If you place 2 lists/tables on one page, and for each table indicate
<body>
<table><tbody class='js-draggable'> .... <tbody></table>
<ul class='js-draggable'> .... </ul>
<div class='js-draggable'> .... </div>
</body>JHtml::_('draggablelist.draggable') ;That code will only work 1 time for the first call.
My correction will allow you to place dragable lists, tables repeatedly on one page.
Actual result BEFORE applying this Pull Request
That code will only work 1 time for the first call.
Expected result AFTER applying this Pull Request
Now the dragable lists/tables will work on one page for each table.
draggable.JS.zip /media/system/js/draggable.js
It is also required to add a loop to sort out all the tables on the page in the draggable.JS file .
They are here in the archive.
But I don’t know which repository to do this.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
| Title |
|
||||||
This pull requests has automatically rebased to 4.2-dev.
This pull requests has been automatically converted to the PSR-12 coding standard.
| Labels |
Added:
?
|
||
| Labels |
Added:
?
Removed: ? |
||
This pull request has been automatically rebased to 4.3-dev.
Can you please extend your testing instructions where this code can be added in a core file so a tester can check the result.
Tell me how you can translate the status of this PR into a draft or disable it. This PR is not completed, there is an error, but it has not been resolved. This PR is 60-70% complete.
for change the status to draft --- click on convert to draft on the left side of your pr
This pull request has been automatically rebased to 4.4-dev.
| Title |
|
||||||
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
@korenevskiy are you still planning to finish this PR?
Can you please extend your testing instructions where this code can be added in a core file so a tester can check the result.