? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
15 Jun 2022

Pull Request for Issue #38031 .

Summary of Changes

removes excessive margin above the webauthn button
makes both button 100% width

Testing Instructions

Apply the pr and check the site login module

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Comment

I created this PR because I was asked to. I have zero opinion on it being a good or bad change.

avatar brianteeman brianteeman - open - 15 Jun 2022
avatar brianteeman brianteeman - change - 15 Jun 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Jun 2022
Category Modules Front End
avatar simbus82 simbus82 - test_item - 15 Jun 2022 - Tested successfully
avatar simbus82
simbus82 - comment - 15 Jun 2022

For the UX it's a really good change! Thanks!

I have tested this item successfully on 11ddf57


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38066.

avatar viocassel viocassel - test_item - 15 Jun 2022 - Tested successfully
avatar viocassel
viocassel - comment - 15 Jun 2022

I have tested this item successfully on 11ddf57


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38066.

avatar alikon alikon - change - 15 Jun 2022
Status Pending Ready to Commit
avatar alikon
alikon - comment - 15 Jun 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38066.

avatar richard67 richard67 - change - 15 Jun 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-06-15 16:44:20
Closed_By richard67
Labels Added: ? ?
avatar richard67 richard67 - close - 15 Jun 2022
avatar richard67 richard67 - merge - 15 Jun 2022
avatar richard67
richard67 - comment - 15 Jun 2022

Thanks all.

Add a Comment

Login with GitHub to post a comment