User tests: Successful: Unsuccessful:
As requested, Joomla 4.2 re-do of Pull Request #28195
Originally Joomla RSS Newsfeeds were completely missing the image_intro and image_fulltext. This was partially fixed with this PR: #11402
But that only introduced the image_intro, and forgot the image_fulltext.
So an article that had an image_fulltext would not use that image in the feed.
This PR simply adds the image_fulltext to the feed if the image_intro is empty, for both the category view and featured view.
| Status | New | ⇒ | Pending |
| Category | ⇒ | Unit Tests Repository Administration com_admin SQL |
| Labels |
Added:
?
|
||
| Category | Unit Tests Repository Administration com_admin SQL | ⇒ | Front End com_content |
@richard67 Should be done :)
@richard67 Should be done :)
@AndySDH Not really. There are still some complaints: https://ci.joomla.org/joomla/joomla-cms/55316/1/6
@AndySDH Still not ok: https://ci.joomla.org/joomla/joomla-cms/55320/1/6 .
Well it's going in circles a bit. If I take out those spaces, the indentation will look off. I'm not sure that's a valid complaint there, not sure.
Well it's going in circles a bit. If I take out those spaces, the indentation will look off. I'm not sure that's a valid complaint there, not sure.
@AndySDH It is a valid complaint. The indentation of the “=“ and the lines below do not need to be aligned. Furthermore the lines below should be indented with tabs. I would also suggest to put the operators “?” and “:” of the ternaries to the beginning of a line and not the end of the previous line. And I would indent the 2nd ternary by one tab more than the first one. Maybe check how it is done elsewhere.
Thanks for the suggestions :) Should be good now hopefully.
This pull requests has been automatically converted to the PSR-12 coding standard.
| Labels |
Added:
?
Maintainers Checked
?
|
||
The images are completely missing from the tags rss feed, can somebody look into this?
If you create a menu item with tags (Menu Item Type: Tagged Items) and check the RSS feed it will contain no images, also the contains the item title, not the category.
@GixxerMKD Solved with PR #38312 .
@GixxerMKD Solved with PR #38312 .
Not same issue, this is the file in question:
components/com_tags/src/View/Tag/FeedView.php
no image for item and wrong code for category:
($feeditem->category = $title;)
This pull request has been automatically rebased to 5.0-dev.
| Title |
|
||||||
| Labels |
Added:
Feature
PR-4.3-dev
PR-5.0-dev
?
Removed: ? ? |
||
Hello, I've updated the code with a cleaner and more simple approach.
Can this be reviewed and merged please?
@laoneo How comes? This is a minor new functionality, should be perfectly fine for a minor release like eg. 4.3 or 4.4.
PS: When you changed the base branch to 5.0, my PR's "commits" got totally screwed up, I only updated 2 files, this now looks like I updated 94 files, which is not the case.
| Category | Front End com_content | ⇒ | Administration com_joomlaupdate com_templates Language & Strings Modules Repository NPM Change Front End com_content Installation |
| Title |
|
||||||
| Category | Front End com_content Administration com_joomlaupdate com_templates Language & Strings Modules Repository NPM Change Installation | ⇒ | Repository Administration com_admin com_banners com_categories com_config com_contact com_content com_fields com_finder com_installer |
| Labels |
Added:
Language Change
NPM Resource Changed
Removed: PR-4.3-dev ? |
||
This pull request has been automatically rebased to 5.1-dev.
Confirmed this works. ✅
I created an article with only a full text image. Left the intro image blank. The feed now will show the full text image in the feed.
I have tested this item ✅ successfully on b2d557e
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
| Category | com_content Administration Repository com_admin com_banners com_categories com_config com_contact com_fields com_finder com_installer | ⇒ | Front End com_content |
Hey there, can this please be merged?
| Labels |
Added:
PR-5.2-dev
Removed: Language Change ? NPM Resource Changed |
||
You need to fic the codestyle issues https://ci.joomla.org/joomla/joomla-cms/76705/1/7
How do I fix? Didn't it use to be automatic with the click of a button? Can't see it anymore
How do I fix? Didn't it use to be automatic with the click of a button? Can't see it anymore
No you have to fix it in your branch and push the changes
And what is the fix I need to make? I can't tell from the phpcs log, it's not very clear.
Thank you, committed :)
Could someone please retrigger drone so we can see what its failing on
Using menu item type "Category Blog" for a feed works as described.
Using menu item type "Featured Articles" for a feed give The requested page can't be found.:
0 No registered feed parser for type error.
| # | Function | Location |
|---|---|---|
| 1 | () | JROOT/libraries/src/Feed/FeedFactory.php:148 |
| 2 | Joomla\CMS\Feed\FeedFactory->_fetchFeedParser() | JROOT/libraries/src/Feed/FeedFactory.php:84 |
| 3 | Joomla\CMS\Feed\FeedFactory->getFeed() | JROOT/components/com_newsfeeds/src/View/Newsfeed/HtmlView.php:180 |
| 4 | Joomla\Component\Newsfeeds\Site\View\Newsfeed\HtmlView->display() | JROOT/libraries/src/MVC/Controller/BaseController.php:697 |
| 5 | Joomla\CMS\MVC\Controller\BaseController->display() | JROOT/components/com_newsfeeds/src/Controller/DisplayController.php:58 |
| 6 | Joomla\Component\Newsfeeds\Site\Controller\DisplayController->display() | JROOT/libraries/src/MVC/Controller/BaseController.php:730 |
| 7 | Joomla\CMS\MVC\Controller\BaseController->execute() | JROOT/libraries/src/Dispatcher/ComponentDispatcher.php:143 |
| 8 | Joomla\CMS\Dispatcher\ComponentDispatcher->dispatch() | JROOT/libraries/src/Component/ComponentHelper.php:361 |
| 9 | Joomla\CMS\Component\ComponentHelper::renderComponent() | JROOT/libraries/src/Application/SiteApplication.php:218 |
| 10 | Joomla\CMS\Application\SiteApplication->dispatch() | JROOT/libraries/src/Application/SiteApplication.php:261 |
| 11 | Joomla\CMS\Application\SiteApplication->doExecute() | JROOT/libraries/src/Application/CMSApplication.php:306 |
| 12 | Joomla\CMS\Application\CMSApplication->execute() | JROOT/includes/app.php:58 |
| 13 | require_once() | JROOT/index.php:32 |
Test System Information:
PHP Built On Darwin Air.local 23.6.0 Darwin Kernel Version 23.6.0: Mon Jul 29 21:13:00 PDT 2024; root:xnu-10063.141.2~1/RELEASE_X86_64 x86_64
Database Type mysql
Database Version 8.0.35
Database Collation utf8mb4_unicode_ci
Database Connection Collation utf8mb4_0900_ai_ci
Database Connection Encryption None
Database Server Supports Connection Encryption Yes
PHP Version 8.3.8
Web Server Apache/2.4.58 (Unix) OpenSSL/1.1.1u mod_fastcgi/mod_fastcgi-SNAP-0910052141
WebServer to PHP Interface cgi-fcgi
Joomla! Version Joomla! 5.2.0-beta2-dev Development [ Uthabiti ] 23-July-2024 16:01 GMT
Joomla Backward Compatibility Plugin Disabled
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:129.0) Gecko/20100101 Firefox/129.0
I have tested this item ✅ successfully on 03ec896
Prebuilt package used for test. First test was by patchtester.
This pull request has been automatically rebased to 5.3-dev.
| Title |
|
||||||
This pull request has been automatically rebased to 6.0-dev.
| Title |
|
||||||
| Labels |
Added:
Updates Requested
PR-6.0-dev
Removed: PR-5.0-dev PR-5.2-dev |
||
@Bodge-IT @QuyTon To be honest I'm not sure what he means. If he wants to make a change, he can make it himself. I'm a bit tired to continue making changes to this PR one small change at a time. This super small PR has been opened for 3 years (5 years if we count the original) and has 41 commits with all the requests. If @QuyTon wants to fix it, you can do it.
Make a commit suggestion with the code change and I can approve it. I'm not an expert coder
Thanks a lot, I committed all the suggestions. Hopefully it's good now!
Thanks @AndySDHm, We'll get it tested...ASP
@Bodge-IT am I doing something wrong, when I test this, the resulting output includes:
<p><img src="https://www.mood-lights.com/_j600//_j600/images/banners/banner.jpg" alt="" width="512" height="512" loading="lazy"></p>
while it should be:
<p><img src="https://www.mood-lights.com/_j600/images/banners/banner.jpg" alt="" width="512" height="512" loading="lazy"></p> to be able to display correctly??
No you're not doing anything wrong, it's adding the basedir in there. Is for me too but mine is just "/"
is it
Sry @brianteeman I read that as 'it is'
... yes, it is doing for both.
it probably needs you to add Uri::root(true)
$item->description = '<p>' . Uri::root(true) . '/' . HTMLHelper::_('image', $obj->image_intro, $obj->image_intro_alt ?? '')
not at my pc so cant check it but it should be something like that
| Labels |
Removed:
Updates Requested
|
||
I have tested this item ✅ successfully on 03ec896
Test Script: Logic verification for FeedView.php fallback mechanism
[TEST 1] Scenario: Intro Image Present, Fulltext Empty
STATUS: PASS
Info: Correctly used Intro Image.
[TEST 2] Scenario: Intro Image Empty, Fulltext Present (The Fix)
STATUS: PASS
Info: Correctly fell back to Fulltext Image.
[TEST 3] Scenario: Both Images Present
STATUS: PASS
Info: Correctly prioritized Intro Image.
I have tested this item ✅ successfully on 03ec896
Tested with 962b2c1 and confirmed the fix
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-04-15 06:25:18 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
bug
Removed: Feature |
||
Sorry my fault, missed this PR when deleting the branch.
| Status | Closed | ⇒ | New |
| Closed_Date | 2026-04-15 06:25:18 | ⇒ | |
| Closed_By | bembelimen | ⇒ |
| Status | New | ⇒ | Pending |
| Title |
|
||||||
I can confirm that this PR does what it says but I am not convinced it is correct.
If I have a page of featured articles that only have full_image then there are no images on the page and that is what I would expect the rss feed to represent
With this PR the rss feed will now include the full_image of each article even thought they are not on the page
Thanks for your time creating this pr, but I have to inform you that maintainer decided on 24.06.2026 to reject this as not wanted.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-06-24 17:12:49 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
RMDQ
PR-6.1-dev
Removed: PR-6.0-dev |
||
I can confirm that this PR does what it says but I am not convinced it is correct.
If I have a page of featured articles that only have full_image then there are no images on the page and that is what I would expect the rss feed to represent
With this PR the rss feed will now include the full_image of each article even thought they are not on the page
Sorry but I have to re-open this and disagree with this.
A RSS feed is a feed to be used externally by other sites to fetch your articles. So each entry in the RSS feed should send the image associated to each article, which can be the Full Article Image if the Intro Image is empty. It doesn't matter if in your own category blog page you don't show images in the article listing. The feed you send to external sites should include a representative image for the article.
PS: Also, the fact that you have no images of a category/featured blog page, it's your experience. On my sites, for example, I have a template override where I do show the full article image in category blog listing in case the intro image is empty.
Thanks for your time creating this pr, but I have to inform you that maintainer decided on 24.06.2026 to reject this as not wanted.
I disagree with this decision, it makes no sense to me, see my reply above.
@AndySDH Could you fix the code style errors reported by drone here https://ci.joomla.org/joomla/joomla-cms/55308/1/6 ? Thanks in advance.