[#38058] - [5.3] Fix for missing Fulltext Image in Newsfeeds
- Pending
- Medium
- Build: 4.1-dev
- # 38058
- Diff
- AndySDH:patch-12
User tests: Successful: Unsuccessful:
As requested, Joomla 4.2 re-do of Pull Request #28195
Summary of Changes
Originally Joomla RSS Newsfeeds were completely missing the image_intro and image_fulltext. This was partially fixed with this PR: #11402
But that only introduced the image_intro, and forgot the image_fulltext.
So an article that had an image_fulltext would not use that image in the feed.
This PR simply adds the image_fulltext to the feed if the image_intro is empty, for both the category view and featured view.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests Repository Administration com_admin SQL |
Quy
- | Labels |
Added:
?
|
||
| Category | Unit Tests Repository Administration com_admin SQL | ⇒ | Front End com_content |
@richard67 Should be done :)
@richard67 Should be done :)
@AndySDH Not really. There are still some complaints: https://ci.joomla.org/joomla/joomla-cms/55316/1/6
@AndySDH Still not ok: https://ci.joomla.org/joomla/joomla-cms/55320/1/6 .
Well it's going in circles a bit. If I take out those spaces, the indentation will look off. I'm not sure that's a valid complaint there, not sure.
Well it's going in circles a bit. If I take out those spaces, the indentation will look off. I'm not sure that's a valid complaint there, not sure.
@AndySDH It is a valid complaint. The indentation of the “=“ and the lines below do not need to be aligned. Furthermore the lines below should be indented with tabs. I would also suggest to put the operators “?” and “:” of the ternaries to the beginning of a line and not the end of the previous line. And I would indent the 2nd ternary by one tab more than the first one. Maybe check how it is done elsewhere.
Thanks for the suggestions :) Should be good now hopefully.
This pull requests has been automatically converted to the PSR-12 coding standard.
| Labels |
Added:
?
Maintainers Checked
?
|
||
The images are completely missing from the tags rss feed, can somebody look into this?
If you create a menu item with tags (Menu Item Type: Tagged Items) and check the RSS feed it will contain no images, also the contains the item title, not the category.
@GixxerMKD Solved with PR #38312 .
@GixxerMKD Solved with PR #38312 .
Not same issue, this is the file in question:
components/com_tags/src/View/Tag/FeedView.php
no image for item and wrong code for category:
($feeditem->category = $title;)
This pull request has been automatically rebased to 5.0-dev.
| Title |
|
||||||
| Labels |
Added:
Feature
PR-4.3-dev
PR-5.0-dev
?
Removed: ? ? |
||
Hello, I've updated the code with a cleaner and more simple approach.
Can this be reviewed and merged please?
@laoneo How comes? This is a minor new functionality, should be perfectly fine for a minor release like eg. 4.3 or 4.4.
PS: When you changed the base branch to 5.0, my PR's "commits" got totally screwed up, I only updated 2 files, this now looks like I updated 94 files, which is not the case.
| Category | Front End com_content | ⇒ | Administration com_joomlaupdate com_templates Language & Strings Modules Repository NPM Change Front End com_content Installation |
obuisard
- | Title |
|
||||||
| Category | Front End com_content Administration com_joomlaupdate com_templates Language & Strings Modules Repository NPM Change Installation | ⇒ | Repository Administration com_admin com_banners com_categories com_config com_contact com_content com_fields com_finder com_installer |
| Labels |
Added:
Language Change
NPM Resource Changed
Removed: PR-4.3-dev ? |
||
This pull request has been automatically rebased to 5.1-dev.
Confirmed this works. ✅
I created an article with only a full text image. Left the intro image blank. The feed now will show the full text image in the feed.
I have tested this item ✅ successfully on b2d557e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38058.
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
| Category | com_content Administration Repository com_admin com_banners com_categories com_config com_contact com_fields com_finder com_installer | ⇒ | Front End com_content |
Hey there, can this please be merged?
| Labels |
Added:
PR-5.2-dev
Removed: Language Change ? NPM Resource Changed |
||
You need to fic the codestyle issues https://ci.joomla.org/joomla/joomla-cms/76705/1/7
How do I fix? Didn't it use to be automatic with the click of a button? Can't see it anymore
How do I fix? Didn't it use to be automatic with the click of a button? Can't see it anymore
No you have to fix it in your branch and push the changes
And what is the fix I need to make? I can't tell from the phpcs log, it's not very clear.
Thank you, committed :)
Could someone please retrigger drone so we can see what its failing on
Using menu item type "Category Blog" for a feed works as described.
Using menu item type "Featured Articles" for a feed give The requested page can't be found.:
0 No registered feed parser for type error.
Call Stack
| # | Function | Location |
|---|---|---|
| 1 | () | JROOT/libraries/src/Feed/FeedFactory.php:148 |
| 2 | Joomla\CMS\Feed\FeedFactory->_fetchFeedParser() | JROOT/libraries/src/Feed/FeedFactory.php:84 |
| 3 | Joomla\CMS\Feed\FeedFactory->getFeed() | JROOT/components/com_newsfeeds/src/View/Newsfeed/HtmlView.php:180 |
| 4 | Joomla\Component\Newsfeeds\Site\View\Newsfeed\HtmlView->display() | JROOT/libraries/src/MVC/Controller/BaseController.php:697 |
| 5 | Joomla\CMS\MVC\Controller\BaseController->display() | JROOT/components/com_newsfeeds/src/Controller/DisplayController.php:58 |
| 6 | Joomla\Component\Newsfeeds\Site\Controller\DisplayController->display() | JROOT/libraries/src/MVC/Controller/BaseController.php:730 |
| 7 | Joomla\CMS\MVC\Controller\BaseController->execute() | JROOT/libraries/src/Dispatcher/ComponentDispatcher.php:143 |
| 8 | Joomla\CMS\Dispatcher\ComponentDispatcher->dispatch() | JROOT/libraries/src/Component/ComponentHelper.php:361 |
| 9 | Joomla\CMS\Component\ComponentHelper::renderComponent() | JROOT/libraries/src/Application/SiteApplication.php:218 |
| 10 | Joomla\CMS\Application\SiteApplication->dispatch() | JROOT/libraries/src/Application/SiteApplication.php:261 |
| 11 | Joomla\CMS\Application\SiteApplication->doExecute() | JROOT/libraries/src/Application/CMSApplication.php:306 |
| 12 | Joomla\CMS\Application\CMSApplication->execute() | JROOT/includes/app.php:58 |
| 13 | require_once() | JROOT/index.php:32 |
Test System Information:
PHP Built On Darwin Air.local 23.6.0 Darwin Kernel Version 23.6.0: Mon Jul 29 21:13:00 PDT 2024; root:xnu-10063.141.2~1/RELEASE_X86_64 x86_64
Database Type mysql
Database Version 8.0.35
Database Collation utf8mb4_unicode_ci
Database Connection Collation utf8mb4_0900_ai_ci
Database Connection Encryption None
Database Server Supports Connection Encryption Yes
PHP Version 8.3.8
Web Server Apache/2.4.58 (Unix) OpenSSL/1.1.1u mod_fastcgi/mod_fastcgi-SNAP-0910052141
WebServer to PHP Interface cgi-fcgi
Joomla! Version Joomla! 5.2.0-beta2-dev Development [ Uthabiti ] 23-July-2024 16:01 GMT
Joomla Backward Compatibility Plugin Disabled
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:129.0) Gecko/20100101 Firefox/129.0
I have tested this item ✅ successfully on 03ec896
Prebuilt package used for test. First test was by patchtester.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38058.
This pull request has been automatically rebased to 5.3-dev.
| Title |
|
||||||
@AndySDH Could you fix the code style errors reported by drone here https://ci.joomla.org/joomla/joomla-cms/55308/1/6 ? Thanks in advance.