bug RMDQ Maintainers Checked PR-6.1-dev Pending

User tests: Successful: Unsuccessful:

avatar AndySDH
AndySDH
14 Jun 2022

As requested, Joomla 4.2 re-do of Pull Request #28195

Summary of Changes

Originally Joomla RSS Newsfeeds were completely missing the image_intro and image_fulltext. This was partially fixed with this PR: #11402

But that only introduced the image_intro, and forgot the image_fulltext.

So an article that had an image_fulltext would not use that image in the feed.

This PR simply adds the image_fulltext to the feed if the image_intro is empty, for both the category view and featured view.

avatar AndySDH AndySDH - open - 14 Jun 2022
avatar AndySDH AndySDH - change - 14 Jun 2022
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Jun 2022
Category ⇒ Unit Tests Repository Administration com_admin SQL
avatar richard67
richard67 - comment - 14 Jun 2022

@AndySDH Could you fix the code style errors reported by drone here https://ci.joomla.org/joomla/joomla-cms/55308/1/6 ? Thanks in advance.

avatar Quy Quy - change - 14 Jun 2022
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 14 Jun 2022
Category Unit Tests Repository Administration com_admin SQL ⇒ Front End com_content
avatar AndySDH
AndySDH - comment - 14 Jun 2022

@richard67 Should be done :)

avatar richard67
richard67 - comment - 14 Jun 2022

@richard67 Should be done :)

@AndySDH Not really. There are still some complaints: https://ci.joomla.org/joomla/joomla-cms/55316/1/6

avatar richard67
richard67 - comment - 14 Jun 2022
avatar AndySDH
AndySDH - comment - 14 Jun 2022

Well it's going in circles a bit. If I take out those spaces, the indentation will look off. I'm not sure that's a valid complaint there, not sure.

avatar richard67
richard67 - comment - 14 Jun 2022

Well it's going in circles a bit. If I take out those spaces, the indentation will look off. I'm not sure that's a valid complaint there, not sure.

@AndySDH It is a valid complaint. The indentation of the “=“ and the lines below do not need to be aligned. Furthermore the lines below should be indented with tabs. I would also suggest to put the operators “?” and “:” of the ternaries to the beginning of a line and not the end of the previous line. And I would indent the 2nd ternary by one tab more than the first one. Maybe check how it is done elsewhere.

avatar AndySDH
AndySDH - comment - 14 Jun 2022

Thanks for the suggestions :) Should be good now hopefully.

avatar joomla-bot
joomla-bot - comment - 27 Jun 2022

This pull requests has been automatically converted to the PSR-12 coding standard.

avatar HLeithner HLeithner - change - 27 Jun 2022
Labels Added: ? Maintainers Checked ?
avatar GixxerMKD
GixxerMKD - comment - 24 Aug 2022

The images are completely missing from the tags rss feed, can somebody look into this?
If you create a menu item with tags (Menu Item Type: Tagged Items) and check the RSS feed it will contain no images, also the contains the item title, not the category.

avatar Franzwohlkoenig
Franzwohlkoenig - comment - 24 Aug 2022

@GixxerMKD Solved with PR #38312 .

avatar GixxerMKD
GixxerMKD - comment - 24 Aug 2022

@GixxerMKD Solved with PR #38312 .

Not same issue, this is the file in question:
components/com_tags/src/View/Tag/FeedView.php

no image for item and wrong code for category:
($feeditem->category = $title;)

avatar HLeithner
HLeithner - comment - 2 May 2023

This pull request has been automatically rebased to 5.0-dev.

avatar AndySDH AndySDH - change - 17 Jun 2023
Title
…
[4.2 re-do] Fix for missing Fulltext Image in Newsfeeds
[4.3 re-do] Fix for missing Fulltext Image in Newsfeeds
avatar AndySDH AndySDH - edited - 17 Jun 2023
avatar AndySDH AndySDH - change - 17 Jun 2023
Labels Added: Feature PR-4.3-dev PR-5.0-dev ?
Removed: ? ?
avatar AndySDH
AndySDH - comment - 17 Jun 2023

Hello, I've updated the code with a cleaner and more simple approach.
Can this be reviewed and merged please?

avatar laoneo
laoneo - comment - 19 Jun 2023

@AndySDH this needs to go into 5.0 earliest. Please leave the base branch.

avatar AndySDH
AndySDH - comment - 19 Jun 2023

@laoneo How comes? This is a minor new functionality, should be perfectly fine for a minor release like eg. 4.3 or 4.4.

PS: When you changed the base branch to 5.0, my PR's "commits" got totally screwed up, I only updated 2 files, this now looks like I updated 94 files, which is not the case.

avatar joomla-cms-bot joomla-cms-bot - change - 15 Jul 2023
Category Front End com_content ⇒ Administration com_joomlaupdate com_templates Language & Strings Modules Repository NPM Change Front End com_content Installation
avatar obuisard obuisard - change - 15 Jul 2023
Title
…
[4.3 re-do] Fix for missing Fulltext Image in Newsfeeds
[5.0] Fix for missing Fulltext Image in Newsfeeds
avatar obuisard obuisard - edited - 15 Jul 2023
avatar joomla-cms-bot joomla-cms-bot - change - 6 Sep 2023
Category Front End com_content Administration com_joomlaupdate com_templates Language & Strings Modules Repository NPM Change Installation ⇒ Repository Administration com_admin com_banners com_categories com_config com_contact com_content com_fields com_finder com_installer
avatar AndySDH AndySDH - change - 6 Sep 2023
Labels Added: Language Change NPM Resource Changed
Removed: PR-4.3-dev ?
avatar HLeithner
HLeithner - comment - 30 Sep 2023

This pull request has been automatically rebased to 5.1-dev.

avatar stimpsonjcat
stimpsonjcat - comment - 24 Feb 2024

Confirmed this works. ✅
I created an article with only a full text image. Left the intro image blank. The feed now will show the full text image in the feed.

avatar stimpsonjcat stimpsonjcat - test_item - 24 Feb 2024 - Tested successfully
avatar stimpsonjcat
stimpsonjcat - comment - 24 Feb 2024

I have tested this item ✅ successfully on b2d557e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38058.

avatar HLeithner
HLeithner - comment - 24 Apr 2024

This pull request has been automatically rebased to 5.2-dev.

avatar HLeithner HLeithner - change - 24 Apr 2024
Title
…
[5.0] Fix for missing Fulltext Image in Newsfeeds
[5.2] Fix for missing Fulltext Image in Newsfeeds
avatar HLeithner HLeithner - edited - 24 Apr 2024
avatar joomla-cms-bot joomla-cms-bot - change - 24 Apr 2024
Category com_content Administration Repository com_admin com_banners com_categories com_config com_contact com_fields com_finder com_installer ⇒ Front End com_content
avatar AndySDH
AndySDH - comment - 13 Jun 2024

Hey there, can this please be merged?

avatar AndySDH AndySDH - change - 13 Jun 2024
Labels Added: PR-5.2-dev
Removed: Language Change ? NPM Resource Changed
avatar brianteeman
brianteeman - comment - 13 Jun 2024

You need to fic the codestyle issues https://ci.joomla.org/joomla/joomla-cms/76705/1/7

avatar AndySDH
AndySDH - comment - 13 Jun 2024

How do I fix? Didn't it use to be automatic with the click of a button? Can't see it anymore

avatar brianteeman
brianteeman - comment - 13 Jun 2024

How do I fix? Didn't it use to be automatic with the click of a button? Can't see it anymore

No you have to fix it in your branch and push the changes

avatar AndySDH
AndySDH - comment - 13 Jun 2024

And what is the fix I need to make? I can't tell from the phpcs log, it's not very clear.

avatar AndySDH
AndySDH - comment - 13 Jun 2024

Thank you, committed :)

avatar brianteeman
brianteeman - comment - 25 Jul 2024

Could someone please retrigger drone so we can see what its failing on

avatar fgsw
fgsw - comment - 30 Aug 2024

Using menu item type "Category Blog" for a feed works as described.

Using menu item type "Featured Articles" for a feed give The requested page can't be found.:

0 No registered feed parser for type error.

Call Stack

# Function Location
1 () JROOT/libraries/src/Feed/FeedFactory.php:148
2 Joomla\CMS\Feed\FeedFactory->_fetchFeedParser() JROOT/libraries/src/Feed/FeedFactory.php:84
3 Joomla\CMS\Feed\FeedFactory->getFeed() JROOT/components/com_newsfeeds/src/View/Newsfeed/HtmlView.php:180
4 Joomla\Component\Newsfeeds\Site\View\Newsfeed\HtmlView->display() JROOT/libraries/src/MVC/Controller/BaseController.php:697
5 Joomla\CMS\MVC\Controller\BaseController->display() JROOT/components/com_newsfeeds/src/Controller/DisplayController.php:58
6 Joomla\Component\Newsfeeds\Site\Controller\DisplayController->display() JROOT/libraries/src/MVC/Controller/BaseController.php:730
7 Joomla\CMS\MVC\Controller\BaseController->execute() JROOT/libraries/src/Dispatcher/ComponentDispatcher.php:143
8 Joomla\CMS\Dispatcher\ComponentDispatcher->dispatch() JROOT/libraries/src/Component/ComponentHelper.php:361
9 Joomla\CMS\Component\ComponentHelper::renderComponent() JROOT/libraries/src/Application/SiteApplication.php:218
10 Joomla\CMS\Application\SiteApplication->dispatch() JROOT/libraries/src/Application/SiteApplication.php:261
11 Joomla\CMS\Application\SiteApplication->doExecute() JROOT/libraries/src/Application/CMSApplication.php:306
12 Joomla\CMS\Application\CMSApplication->execute() JROOT/includes/app.php:58
13 require_once() JROOT/index.php:32

Test System Information:

PHP Built On Darwin Air.local 23.6.0 Darwin Kernel Version 23.6.0: Mon Jul 29 21:13:00 PDT 2024; root:xnu-10063.141.2~1/RELEASE_X86_64 x86_64
Database Type mysql
Database Version 8.0.35
Database Collation utf8mb4_unicode_ci
Database Connection Collation utf8mb4_0900_ai_ci
Database Connection Encryption None
Database Server Supports Connection Encryption Yes
PHP Version 8.3.8
Web Server Apache/2.4.58 (Unix) OpenSSL/1.1.1u mod_fastcgi/mod_fastcgi-SNAP-0910052141
WebServer to PHP Interface cgi-fcgi
Joomla! Version Joomla! 5.2.0-beta2-dev Development [ Uthabiti ] 23-July-2024 16:01 GMT
Joomla Backward Compatibility Plugin Disabled
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:129.0) Gecko/20100101 Firefox/129.0

avatar AndySDH
AndySDH - comment - 30 Aug 2024

@fgsw Doesn't seem related to this PR. The file changed in this PR has nothing to do with the error trace you've shown.

avatar fgsw fgsw - test_item - 31 Aug 2024 - Tested successfully
avatar fgsw
fgsw - comment - 31 Aug 2024

I have tested this item ✅ successfully on 03ec896

Prebuilt package used for test. First test was by patchtester.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38058.

avatar HLeithner
HLeithner - comment - 2 Sep 2024

This pull request has been automatically rebased to 5.3-dev.

avatar HLeithner HLeithner - change - 2 Sep 2024
Title
…
[5.2] Fix for missing Fulltext Image in Newsfeeds
[5.3] Fix for missing Fulltext Image in Newsfeeds
avatar HLeithner HLeithner - edited - 2 Sep 2024
avatar HLeithner
HLeithner - comment - 4 Mar 2025

This pull request has been automatically rebased to 6.0-dev.

avatar HLeithner HLeithner - change - 4 Mar 2025
Title
…
[5.3] Fix for missing Fulltext Image in Newsfeeds
[6.0] Fix for missing Fulltext Image in Newsfeeds
avatar HLeithner HLeithner - edited - 4 Mar 2025
avatar Bodge-IT
Bodge-IT - comment - 4 Jun 2025

@AndySDH, RM here, looking at this feature for 6.0 and we like it. Could you check Quy's comment? Thanks.

avatar AndySDH AndySDH - change - 4 Jun 2025
Labels Added: Updates Requested PR-6.0-dev
Removed: PR-5.0-dev PR-5.2-dev
avatar AndySDH
AndySDH - comment - 4 Jun 2025

@Bodge-IT Thanks, I fixed the error he mentioned.

avatar Bodge-IT
Bodge-IT - comment - 12 Jun 2025

@AndySDH can you look into Quy's change request?

avatar AndySDH
AndySDH - comment - 12 Jun 2025

@Bodge-IT @QuyTon To be honest I'm not sure what he means. If he wants to make a change, he can make it himself. I'm a bit tired to continue making changes to this PR one small change at a time. This super small PR has been opened for 3 years (5 years if we count the original) and has 41 commits with all the requests. If @QuyTon wants to fix it, you can do it.

avatar Bodge-IT
Bodge-IT - comment - 12 Jun 2025

Hi @AndySDH he's merely suggesting you consider moving the 2 lines setting properties inside the their respective ifs like:
HTMLHelper::_('image', $obj->image_intro, $obj->image_intro_alt ?? '')

avatar AndySDH
AndySDH - comment - 12 Jun 2025

Make a commit suggestion with the code change and I can approve it. I'm not an expert coder

avatar AndySDH
AndySDH - comment - 13 Jun 2025

Thanks a lot, I committed all the suggestions. Hopefully it's good now!

avatar Bodge-IT
Bodge-IT - comment - 16 Jun 2025

Thanks @AndySDHm, We'll get it tested...ASP

avatar exlemor
exlemor - comment - 16 Jul 2025

@Bodge-IT am I doing something wrong, when I test this, the resulting output includes:

<p><img src="https://www.mood-lights.com/_j600//_j600/images/banners/banner.jpg" alt="" width="512" height="512" loading="lazy"></p>

while it should be:

<p><img src="https://www.mood-lights.com/_j600/images/banners/banner.jpg" alt="" width="512" height="512" loading="lazy"></p> to be able to display correctly??

avatar Bodge-IT
Bodge-IT - comment - 23 Jul 2025

No you're not doing anything wrong, it's adding the basedir in there. Is for me too but mine is just "/"

avatar brianteeman
brianteeman - comment - 23 Jul 2025

@Bodge-IT @exlemor is it also doing this for the introtext image

avatar Bodge-IT
Bodge-IT - comment - 30 Jul 2025

is it

Sry @brianteeman I read that as 'it is'
... yes, it is doing for both.

avatar Bodge-IT
Bodge-IT - comment - 8 Aug 2025

Hi @AndySDH we're still looking to get this in 6.0. Having looked at the issue detailed by @exlemor above, we need the basedir excluded from the path in your code. Could you review please?

avatar AndySDH
AndySDH - comment - 8 Aug 2025

@Bodge-IT Not sure how to do that. If somebody can take over and do it that would be great.

avatar brianteeman
brianteeman - comment - 8 Aug 2025

it probably needs you to add Uri::root(true)

$item->description = '<p>' . Uri::root(true) . '/' . HTMLHelper::_('image', $obj->image_intro, $obj->image_intro_alt ?? '')

not at my pc so cant check it but it should be something like that

avatar Bodge-IT Bodge-IT - change - 14 Aug 2025
Labels Removed: Updates Requested
avatar vishalchincholi1 vishalchincholi1 - test_item - 30 Jan 2026 - Tested successfully
avatar vishalchincholi1
vishalchincholi1 - comment - 30 Jan 2026

I have tested this item ✅ successfully on 03ec896

Test Script: Logic verification for FeedView.php fallback mechanism
[TEST 1] Scenario: Intro Image Present, Fulltext Empty
STATUS: PASS
Info: Correctly used Intro Image.
[TEST 2] Scenario: Intro Image Empty, Fulltext Present (The Fix)
STATUS: PASS
Info: Correctly fell back to Fulltext Image.
[TEST 3] Scenario: Both Images Present
STATUS: PASS
Info: Correctly prioritized Intro Image.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38058.

avatar kkbiswal kkbiswal - test_item - 30 Jan 2026 - Tested successfully
avatar kkbiswal
kkbiswal - comment - 30 Jan 2026

I have tested this item ✅ successfully on 03ec896

Tested with 962b2c1 and confirmed the fix


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38058.

avatar bembelimen bembelimen - change - 15 Apr 2026
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2026-04-15 06:25:18
Closed_By ⇒ bembelimen
Labels Added: bug
Removed: Feature
avatar bembelimen bembelimen - close - 15 Apr 2026
avatar bembelimen
bembelimen - comment - 15 Apr 2026

Sorry my fault, missed this PR when deleting the branch.

avatar bembelimen bembelimen - change - 15 Apr 2026
Status Closed ⇒ New
Closed_Date 2026-04-15 06:25:18 ⇒
Closed_By bembelimen ⇒
avatar bembelimen bembelimen - change - 15 Apr 2026
Status New ⇒ Pending
avatar bembelimen bembelimen - reopen - 15 Apr 2026
avatar tecpromotion tecpromotion - change - 15 Apr 2026
Title
…
[6.0] Fix for missing Fulltext Image in Newsfeeds
[6.1] Fix for missing Fulltext Image in Newsfeeds
avatar tecpromotion tecpromotion - edited - 15 Apr 2026
avatar brianteeman
brianteeman - comment - 8 May 2026

I can confirm that this PR does what it says but I am not convinced it is correct.

If I have a page of featured articles that only have full_image then there are no images on the page and that is what I would expect the rss feed to represent

With this PR the rss feed will now include the full_image of each article even thought they are not on the page

avatar HLeithner HLeithner - close - 24 Jun 2026
avatar HLeithner
HLeithner - comment - 24 Jun 2026

Thanks for your time creating this pr, but I have to inform you that maintainer decided on 24.06.2026 to reject this as not wanted.

avatar HLeithner HLeithner - change - 24 Jun 2026
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2026-06-24 17:12:49
Closed_By ⇒ HLeithner
Labels Added: RMDQ PR-6.1-dev
Removed: PR-6.0-dev
avatar AndySDH
AndySDH - comment - 16 Sep 2026

I can confirm that this PR does what it says but I am not convinced it is correct.

If I have a page of featured articles that only have full_image then there are no images on the page and that is what I would expect the rss feed to represent

With this PR the rss feed will now include the full_image of each article even thought they are not on the page

Sorry but I have to re-open this and disagree with this.

A RSS feed is a feed to be used externally by other sites to fetch your articles. So each entry in the RSS feed should send the image associated to each article, which can be the Full Article Image if the Intro Image is empty. It doesn't matter if in your own category blog page you don't show images in the article listing. The feed you send to external sites should include a representative image for the article.

PS: Also, the fact that you have no images of a category/featured blog page, it's your experience. On my sites, for example, I have a template override where I do show the full article image in category blog listing in case the intro image is empty.

avatar AndySDH
AndySDH - comment - 16 Sep 2026

Thanks for your time creating this pr, but I have to inform you that maintainer decided on 24.06.2026 to reject this as not wanted.

I disagree with this decision, it makes no sense to me, see my reply above.

Add a Comment

Login with GitHub to post a comment