[#38057] - [4.2 re-do] Fix for Broken html in Date of Birth field in User Profile Form
- Closed
- 15 Jun 2022
- Medium
- Build: 4.1-dev
- # 38057
- Diff
- AndySDH:patch-23
User tests: Successful: Unsuccessful:
As requested, here's the Joomla 4.2 Re-Do of Pull Request #28884 (which was for Issue #28883).
Summary of Changes
This fixes the Date of Birth field in User Profile Edit Form that generates a broken html.
The issue is to due the extra info about the date format being added with broken html around it.
I've also update the language string to be shorter in order to fit the new positioning better. See the original PR #28884 for more details/discussion.
Previous result
The previous "hacky" HTML creates an extra control-group, and the actual "controls" is outside of it, so two problems for the price of one.
The goal was to put the info language string on a separate line but this breaks the HTML structure of the form.
New result
Now the info sits near the label and doesn't break the HTML of the control-group. It does occupy a bit more space (with the default layout) but now the HTML is valid
Testing Instructions
Simply see the HTML of the edit form of a user profile page with a DOB field enabled.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests Repository Administration com_admin SQL |
| Labels |
Added:
?
?
|
||
| Category | Unit Tests Repository Administration com_admin SQL | ⇒ | Administration Language & Strings Layout Front End Plugins |
| Labels |
Added:
Language Change
?
Removed: ? ? |
||
To be honest I agree. But I wasn't / am not sure how to go about completely removing a layout. So if you know how to do so, please be my guest, I do agree with you that a simple hint would be enough.
Don't add hint="YYYY-MM-DD" because DD.MM.YYYY is correct for Russian/Ukrainian and many other languages.
The hint is a translatable string
@brianteeman Can you make a new PR with your idea of making it a calendar field with the hint?
I'll close this in favor of @brianteeman's PR.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-06-15 09:36:45 |
| Closed_By | ⇒ | AndySDH |
What am I missing? Surely this just needs a regular field of type calendar and no extra fields or layouts
or could also include a hint