? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
12 Jun 2022

Pull Request for Issue # .

Summary of Changes

Update the lists of files and folders to be deleted on update by script.php to the latest changes in the 4.2-dev branch in preparation of the upcoming 4.2.0 Beta 2.

Following files and folder from following PR's are included (note that this includes the old location of moved files):

  • From PR #37928 file "plugins/behaviour/taggable/taggable.php".
  • From PR #37929 file "plugins/behaviour/versionable/versionable.php".
  • From PR #37947 file "modules/mod_articles_latest/mod_articles_latest.php".
  • From PR #37954 file "plugins/task/requests/requests.php".
  • From PR #38065 files "layouts/plugins/user/profile/fields/dob.php" and "plugins/user/profile/src/Field/DobField.php" and folders "layouts/plugins/user/profile/fields" and "layouts/plugins/user/profile".
  • From PR #38097 file "plugins/task/sitestatus/sitestatus.php".

Testing Instructions

Code review.

Or if you want to make a real test, update a 4.2.0-beta1 to the last 4.2 nightly build to get the actual result, and update a 4.2.0-beta1 to the update package built by Drone for this PR to get the expected result.

Actual result BEFORE applying this Pull Request

Files and folders mentioned in the description above are still present after updating from 4.2.0-beta1.

Expected result AFTER applying this Pull Request

All files and folders mentioned in the description above have been deleted after updating from 4.2.0-beta1.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 12 Jun 2022
avatar richard67 richard67 - change - 12 Jun 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Jun 2022
Category Administration com_admin
avatar sandewt sandewt - test_item - 13 Jun 2022 - Tested successfully
avatar sandewt
sandewt - comment - 13 Jun 2022

I have tested this item successfully on 189027b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38039.

avatar richard67
richard67 - comment - 13 Jun 2022

@sandewt Thanks for your test. Unfortunately it doesn't make much sense since this PR is in draft status and clearly marked as WiP (work in progress) in the title and the description because there might be more PRs merged into 4.2-dev before the next beta release and so more files have to be added to this PR here. So I suggest to wait with testing until the PR is ready (not draft anymore). But very likely the release leads will merge it by review when time has come.

avatar sandewt
sandewt - comment - 13 Jun 2022

@richard67

I will wait ?

avatar richard67 richard67 - change - 16 Jun 2022
Labels Added: ?
avatar richard67 richard67 - change - 16 Jun 2022
The description was changed
avatar richard67 richard67 - edited - 16 Jun 2022
avatar richard67 richard67 - change - 16 Jun 2022
The description was changed
avatar richard67 richard67 - edited - 16 Jun 2022
avatar richard67 richard67 - change - 19 Jun 2022
Title
[4.2] [WiP] Update deleted files and folders for 4.2.0-beta2
[4.2] Update deleted files and folders for 4.2.0-beta2
avatar richard67 richard67 - edited - 19 Jun 2022
avatar richard67 richard67 - change - 19 Jun 2022
The description was changed
avatar richard67 richard67 - edited - 19 Jun 2022
avatar richard67
richard67 - comment - 19 Jun 2022

@sandewt The PR is ready now. So if you still can find the time for testing, it would be welcome.

avatar richard67
richard67 - comment - 20 Jun 2022

Ping @roland-d .

avatar sandewt sandewt - test_item - 20 Jun 2022 - Tested successfully
avatar sandewt
sandewt - comment - 20 Jun 2022

I have tested this item successfully on a59ef13

Code review.

Done

Or if you want to make a real test, update a 4.2.0-beta1 to the last 4.2 nightly build to get the actual result, and update a 4.2.0-beta1 to the update package built by Drone for this PR to get the expected result.

Done


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38039.

avatar richard67
richard67 - comment - 20 Jun 2022

@sandewt Thanks.

avatar richard67 richard67 - change - 20 Jun 2022
The description was changed
avatar richard67 richard67 - edited - 20 Jun 2022
avatar roland-d roland-d - change - 20 Jun 2022
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-06-20 22:14:36
Closed_By roland-d
avatar roland-d roland-d - close - 20 Jun 2022
avatar roland-d roland-d - merge - 20 Jun 2022
avatar roland-d
roland-d - comment - 20 Jun 2022

Thank you

Add a Comment

Login with GitHub to post a comment