? Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar tecpromotion
tecpromotion
12 Jun 2022

Summary of Changes

Unified spelling of the word YubiKey.

Testing Instructions

.

Actual result BEFORE applying this Pull Request

Mix of YubiKey and Yubikey

Expected result AFTER applying this Pull Request

YubiKey

Documentation Changes Required

.

avatar tecpromotion tecpromotion - open - 12 Jun 2022
avatar tecpromotion tecpromotion - change - 12 Jun 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Jun 2022
Category Administration Language & Strings
avatar tecpromotion tecpromotion - change - 12 Jun 2022
Labels Added: Language Change ?
avatar richard67
richard67 - comment - 12 Jun 2022

@roland-d Should @tecpromotion revert the changes in the 2 "plg_twofactorauth_yubikey*.ini" files because those will be merged up later from 4.1-dev when his PR #38037 has bee merged into the 4.1-dev branch, and having the same changes here will cause a merge conflict? Or are you ok with that?

avatar roland-d
roland-d - comment - 12 Jun 2022

@richard67 That should be OK, because the same lines are changed Git will know what to do with it. If not, I can fix the merge conflict, should be easy.

7c73dd4 12 Jun 2022 avatar tecpromotion fix
avatar richard67 richard67 - test_item - 13 Jun 2022 - Tested successfully
avatar richard67
richard67 - comment - 13 Jun 2022

I have tested this item successfully on 9438f51


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38036.

avatar Quy Quy - test_item - 13 Jun 2022 - Tested successfully
avatar Quy
Quy - comment - 13 Jun 2022

I have tested this item successfully on 9438f51


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38036.

avatar Quy Quy - change - 13 Jun 2022
Status Pending Ready to Commit
avatar Quy
Quy - comment - 13 Jun 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38036.

avatar laoneo laoneo - change - 13 Jun 2022
Labels Added: ?
avatar roland-d roland-d - close - 13 Jun 2022
avatar roland-d roland-d - merge - 13 Jun 2022
avatar roland-d roland-d - change - 13 Jun 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-06-13 19:54:49
Closed_By roland-d
avatar roland-d
roland-d - comment - 13 Jun 2022

Thanks everybody

Add a Comment

Login with GitHub to post a comment