? Release Blocker ? Maintainers Checked Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
12 Jun 2022

Pull Request for Issue # .

Summary of Changes

This PR fixes fatal error on Users Management when none Multi-factor Authentication plugins enabled on Joomla 4.2.

Testing Instructions

  1. Use Joomla 4.2 nightly build
  2. Go to Users -> Manager

Actual result BEFORE applying this Pull Request

Get fatal error Call to a member function getGroup() on null

Expected result AFTER applying this Pull Request

The error is gone

avatar joomdonation joomdonation - open - 12 Jun 2022
avatar joomdonation joomdonation - change - 12 Jun 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Jun 2022
Category Administration com_users
avatar Kostelano Kostelano - test_item - 12 Jun 2022 - Tested successfully
avatar Kostelano
Kostelano - comment - 12 Jun 2022

I have tested this item successfully on 77886e4

I can confirm the error and that this PR fixes it.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38034.

avatar richard67
richard67 - comment - 12 Jun 2022

@joomdonation The patch fixes the issue, but now the users list shows the MFA as activated when there is none of the plugins of type "multifactorauth" enabled:

I think your PR does the right thing but unmasks another glitch, possibly in the view or the layout.

Do you think you can fix that, too? If not, I can open a new issue for it.

Update: Silly me, I was confused. All ok.

avatar richard67 richard67 - test_item - 12 Jun 2022 - Tested successfully
avatar richard67
richard67 - comment - 12 Jun 2022

I have tested this item successfully on 77886e4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38034.

avatar richard67 richard67 - change - 12 Jun 2022
Status Pending Ready to Commit
Labels Added: Release Blocker ?
avatar richard67
richard67 - comment - 12 Jun 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38034.

avatar richard67 richard67 - change - 12 Jun 2022
Labels Added: ?
avatar richard67 richard67 - alter_testresult - 12 Jun 2022 - Kostelano: Tested successfully
avatar richard67 richard67 - alter_testresult - 12 Jun 2022 - richard67: Tested successfully
avatar richard67 richard67 - change - 12 Jun 2022
Title
[4.2] Fix fatal errors on users Management
[4.2] Fix fatal error on users management
avatar richard67 richard67 - edited - 12 Jun 2022
avatar roland-d roland-d - change - 12 Jun 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-06-12 12:16:40
Closed_By roland-d
Labels Added: Maintainers Checked
avatar roland-d roland-d - close - 12 Jun 2022
avatar roland-d roland-d - merge - 12 Jun 2022
avatar roland-d
roland-d - comment - 12 Jun 2022

Thanks everybody

Add a Comment

Login with GitHub to post a comment