Feeling Lucky
?
[#38022] - [4.2] Remove unnecessary $this->app->getIdentity() check
- Closed
- 10 Jun 2022
- Medium
- Build: 4.2-dev
- # 38022
- Diff
- joomdonation:remove_unnecessary_getidentity_check
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
As pointed out in my comment #38011 (comment), $this->app->getIdentity() will always return a User object, so the check here could be removed.
Testing Instructions
- Use Joomla 4.2 nightly build
- Apply patch
- Access to Articles Management screen from backend, make sure nothing is broken.
Actual result BEFORE applying this Pull Request
Works but there is unnecessary code.
Expected result AFTER applying this Pull Request
Works
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
joomdonation
- comment
- 10 Jun 2022
@richard67 Sorry, I did not check installation. The installation app does not initialize the identity object like our other apps, so the change in this PR is causing an error.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-06-10 00:58:17 |
| Closed_By | ⇒ | joomdonation | |
| Labels |
Added:
?
|
||
@joomdonation The installation at the beginning of the api tests in drone fails. I’ r restarted drone 3 times now but always the same result. Are you sure the removed code was useless? Have you tested to make a new installation with your changes?