[#38009] - [4.2] accessibility plugin update and fixes
- Fixed in Code Base
- 14 Jun 2022
- Medium
- Build: 4.1-dev
- # 38009
- Diff
- brianteeman:emojia11y
User tests: Successful: Unsuccessful:
Summary of Changes
#36948 changed the icons in the accessibility from the google material font (because :privacy :facepalm) to use emojis.
Fixes #37050
Fixes #36311
At the time this also resolved a bug in the upstream code that prevented the material font working on osx
Upstream has now resolved the osx problem.
This PR updates to the latest release of the script and introduces the ability to use either emoji or material icons. The default is emoji so there is no visible change etc on upgrade and no need for an update sql.
It;s now a user choice if they want to use the better material font icons
Testing Instructions
Either use a prebuilt package or apply the pull request and then npm i
Expected result AFTER applying this Pull Request
New Option in the plugin
With Emojis
.
With Google Material Font
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings NPM Change Front End Plugins |
| Labels |
Added:
Language Change
NPM Resource Changed
?
|
||
I've restored the previous human test in the issue tracker since the commit which has invalidated the test count was just a code style change.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38009.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38009.
Any reason you made this for 4.1? As this introduces a new feature it should go into 4.2.
Because it fixes a bug that should never have been merged
But then I would split the pr into a bug fix one and a new feature, when you want to have the bug fix into 4.1. As soon as a pr has a new feature, it should come into the next minor, even when it also fixes a bug.
thats just a waste of time.
| Status | Ready to Commit | ⇒ | Pending |
Putting it back to pending
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38009.
should still be rtc and set to RLDQ
I'm putting it back to RTC when rebased.
4.1 is the correct branch
| Labels |
Added:
?
|
||
| Title |
|
||||||
| Labels |
Added:
?
|
||
Can you rebuild the lock file, so we can merge it. Thanks.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38009.
For safety I would recreate the lock file, that's why I didn't remove it. See my comment here #38009 (comment).
| Labels |
Added:
?
Removed: ? |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-06-14 08:06:02 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Removed:
?
|
||
Thanks for your cooperation!!
well i didnt have a choice even though it is completely wrong to merge into 4.2
Hello, i'm not sure if this is the right place for this suggestion. So i'm happy to get Feedback if not.
In my opinion it would be a better way to load the material icons local and use these, instead of the emoji version.
I tried a simple hack and uploaded a material-icons.css and the icon font to my server and replace the the url with the fonts.goolge… .
Everthing works and i can use the material icons (which are much easier to see in my eyes). Do you think it is possible to add another dropdown option (e.g. Material Icons local) with a hint where to download the Font and a CSS Sample to include and where to place it on the server (e.g. in "my-template/css")? Or to upload the font directly in plugin options?
If not, is it possible to create an overwrite for media/vendor/accessibility/js/accessibility.min.js ?
I didn't find any option to do this.
I have tested this item✅ successfully on 915bf8a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38009.