[#38005] - [inlinehelp] Add inlinehelp toggle button for each component config
- Fixed in Code Base
- 10 Jun 2022
- Medium
- Build: 4.1-dev
- # 38005
- Diff
- cyrezdev:patch-49
User tests: Successful: Unsuccessful:
Pull Request to add the inlinehelp button in each component configuration where descriptions are present.
Summary of Changes
Added to the following components:
- Banners > com_banners
- Contacts > com_contact
- Installer > com_installer
- Joomla! Update > com_joomlaupdate
- Mail Templates > com_mails
- Media > com_media
- Modules > com_modules
- News Feeds > com_newsfeeds
- Privacy > com_privacy
- Redirects > com_redirect
- Sheduled Tasks > com_sheduler
- Smart Search > com_finder
- Users > com_users
Config (com_config) and Articles (com_content) already merged to 4.1
Testing Instructions
- Check component config, and test inlinehelp toggle button everywhere this one is display and control it works as expected (descriptions hidden by default).
Actual result BEFORE applying this Pull Request
Inlinehelp button only on global config and articles configs.
Expected result AFTER applying this Pull Request
inlinehelp button everywhere in component's config where descriptions are available.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_contact com_finder com_installer com_media com_modules com_newsfeeds com_redirect com_users |
| Title |
|
||||||
I support @conseilgouz, we must implement this change in all active components, regardless of the presence of a description for the parameters.
I support @conseilgouz, we must implement this change in all active components, regardless of the presence of a description for the parameters.
This will be for another PR, when your PR will be complete, tested and RTC ;-)
| Title |
|
||||||
| Labels |
Added:
?
|
||
| Category | Administration com_banners com_contact com_finder com_installer com_media com_modules com_newsfeeds com_redirect com_users | ⇒ | Administration com_banners com_contact com_finder com_installer com_joomlaupdate com_media com_modules com_newsfeeds com_redirect com_users |
@conseilgouz @Kostelano
i've done the second PR to be ready for when PR #37915 will be RTC.
See here for PART2: #38014
Some components are to be done:
* com_actionlogs * com_joomlaupdate * com_menu * com_search * com_tags * com_templates
com_joomlaupdate is in this PR.
com_search does not exist anymore (see com_finder in this PR for Smart Search).
;-)
@Kostelano don't hesitate to test ;-)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38005.
com_search does not exist anymore (see com_finder in this PR for Smart Search).
It will "appear" in 4.x if you upgrade from 3.10. True, there are many differences in styling, including buttons. So the lack of a hint/description switch isn't the worst thing.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38005.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38005.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-06-10 19:26:37 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
|
||
Thx
Some components are to be done:
Note : com_actionlogs, com_menu, com_tags, com_templates have no description at the moment, but may be useful. Useless inlinehelp buttons will be hidden if you apply #37915