? ? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
6 Jun 2022

Pull Request for Issue #37991 .

Summary of Changes

do not check password on PATCH

Testing Instructions

see #37991

Actual result BEFORE applying this Pull Request

Status : 400 : Bad request

Expected result AFTER applying this Pull Request

HTTP response 200

avatar alikon alikon - open - 6 Jun 2022
avatar alikon alikon - change - 6 Jun 2022
Status New Pending
avatar toivo toivo - test_item - 6 Jun 2022 - Tested unsuccessfully
avatar toivo
toivo - comment - 6 Jun 2022

I have tested this item ? unsuccessfully on 4eb45ab

Modified the example in the Postman collection and sent the following JSON as Patch: {'email': 'new@example.org','groups': ['2'],'name': 'name','username': 'username'}

Received the error:

{
    "errors": [
        {
            "title": "Save failed with the following error: You can't save a user account without selecting at least one user group.",
            "code": 400
        }
    ]
}
```<hr /><sub>This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="https://issues.joomla.org/tracker/joomla-cms/37994">issues.joomla.org/tracker/joomla-cms/37994</a>.</sub>
avatar alikon
alikon - comment - 6 Jun 2022

@toivo which version ? 4.2 or 4.1

avatar alikon alikon - change - 6 Jun 2022
Labels Added: ? ?
avatar toivo
toivo - comment - 6 Jun 2022

@alikon I was testing in 4.1

avatar alikon
alikon - comment - 6 Jun 2022

@toivo i got that message when i don't pass groups which is mandatory
{"email": "new@example.org","name": "name","username": "username"}

avatar aftertaf aftertaf - test_item - 6 Jun 2022 - Tested successfully
avatar aftertaf
aftertaf - comment - 6 Jun 2022

I have tested this item successfully on 14830e8

Works with this new code.
Asked if we can also not have to set the groups attribute, as we may not me updating user/group memeberships via API calls.
But this fix is working when I also PATCH the Group:

e.g.
{"email":"hello@nowhere.com","groups":["2"], "other_custom_field": "0"}

PASS
Successful 2xx request


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37994.

avatar toivo toivo - test_item - 6 Jun 2022 - Tested successfully
avatar toivo
toivo - comment - 6 Jun 2022

I have tested this item successfully on 14830e8

Tested successfully in Joomla 4.1.5-dev using Postman and PHP 8.0.15.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37994.

avatar richard67 richard67 - change - 6 Jun 2022
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 6 Jun 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37994.

avatar bembelimen bembelimen - change - 10 Jun 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-06-10 14:05:29
Closed_By bembelimen
Labels Added: ?
avatar bembelimen bembelimen - close - 10 Jun 2022
avatar bembelimen bembelimen - merge - 10 Jun 2022
avatar bembelimen
bembelimen - comment - 10 Jun 2022

Thx

Add a Comment

Login with GitHub to post a comment