? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
1 Jun 2022

Summary of Changes

Changes the requests task plugin to service provider. Additionally some untranslated strings are fixed and the manifest file is cleaned up.

The change in the TaskPluginTrait.php is needed, so forms are loaded from the forms folder in the root of the plugin.

Testing Instructions

  • Create a GET request task in the task scheduler extension
  • Run the task manually

Actual result BEFORE applying this Pull Request

All works.

Expected result AFTER applying this Pull Request

All works.

avatar laoneo laoneo - open - 1 Jun 2022
avatar laoneo laoneo - change - 1 Jun 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jun 2022
Category Administration Front End Plugins
d1cde23 1 Jun 2022 avatar laoneo typo
avatar laoneo laoneo - change - 1 Jun 2022
Labels Added: ?
avatar richard67
richard67 - comment - 1 Jun 2022

Somehow this PR seems to show unrelated changes on GitHub, as if the branch had been rebased.

Sorry, was looking at the wrong PR.

4d793c9 1 Jun 2022 avatar laoneo tabs
avatar heelc29
heelc29 - comment - 2 Jun 2022

Can you remove the version attribute?

<extension version="4.1" type="plugin" group="task" method="upgrade">

avatar laoneo
laoneo - comment - 2 Jun 2022

done

avatar laoneo laoneo - change - 2 Jun 2022
The description was changed
avatar laoneo laoneo - edited - 2 Jun 2022
avatar roland-d roland-d - change - 8 Jun 2022
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-06-08 07:19:20
Closed_By roland-d
avatar roland-d roland-d - close - 8 Jun 2022
avatar roland-d roland-d - merge - 8 Jun 2022
avatar roland-d
roland-d - comment - 8 Jun 2022

Thanks everybody

Add a Comment

Login with GitHub to post a comment