Feeling Lucky
?
?
[#37941] - [4.2] Fix uninitialized version variable in installer library
- Fixed in Code Base
- 1 Jun 2022
- Medium
- Build: 4.2-dev
- # 37941
- Diff
- richard67:4.2-dev-fix-uninitialized-version-variable-in-installer
User tests: Successful: Unsuccessful:
Pull Request for Issue #37934 .
Summary of Changes
Move the log of the version number on schema updates to below the code where the version number is set.
Testing Instructions
See issue #37934 .
But code review should be sufficient.
See also my comment in the issue why it is only a 4.2-dev issue and ok in 4.1-dev: #37934 (comment)
Actual result BEFORE applying this Pull Request
No installer error.
Expected result AFTER applying this Pull Request
PHP warning about uninitialized variable $version being used at line 1334 of file libraries/src/Installer/Installer.php.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
alikon
- comment
- 1 Jun 2022
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37941.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 1 Jun 2022
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37941.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-06-01 19:11:16 |
| Closed_By | ⇒ | roland-d |
roland-d
- comment
- 1 Jun 2022
Thanks everybody
I have tested this item✅ successfully on 4b0ee24
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37941.