[#37937] - Update MailTemplate.php
- Closed
- 16 Aug 2023
- Medium
- Build: 4.1-dev
- # 37937
- Diff
- rigin:patch-11
User tests: Successful: Unsuccessful:
The method does not bind the template to the extension. And I propose to correct this omission.
Pull Request for Issue # .
Summary of Changes
When using this method, the 'extension' field remains empty and, accordingly, the template is not visible in the list of templates.
I added a parameter to insert it.If it is not used, then the 'extension' field is filled with the contents of the 'name' field before the '.' separator.
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
This is a change in another class method.
They can be considered in parallel.
From: Richard Fath @.***
Sent: Tuesday, May 31, 2022 4:35 PM
To: joomla/joomla-cms
Cc: Vadim Rigin; Mention
Subject: Re: [joomla/joomla-cms] Update MailTemplate.php (PR #37937)
@rigin https://github.com/rigin Does this PR here replace your PR #37898
#37898 from 6 days ago? If so,
why haven't you closed it?
Reply to this email directly, view
#37937 (comment)
it on GitHub, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAG4ZLLT7DCZECYHHDWQ4STVM
YIQNANCNFSM5XNIW2LQ> .
You are receiving this because you were mentioned.
<https://github.com/notifications/beacon/AAG4ZLOEYYF4DYUQXHKFIOTVMYIQNA5CNFS
M5XNIW2L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOIQJ35XI
.gif> Message ID: @.***>
This pull requests has automatically rebased to 4.2-dev.
This pull requests has been automatically converted to the PSR-12 coding standard.
| Labels |
Added:
?
?
|
||
This pull request has been automatically rebased to 4.3-dev.
Thank you for your contribution. Closing for stated reason.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-08-16 16:56:16 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
Information Required
bug
PR-4.3-dev
?
Removed: ? ? |
||
@rigin Does this PR here replace your PR #37898 from 6 days ago? If so, why haven't you closed it?