? ? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
30 May 2022

Summary of Changes

Change versions plugin to service provider. Did also some code style cleanup.

Testing Instructions

  • Enable versions in the articles global options
  • Open the article form
  • Set a title
  • Set a description
  • Save (NOT close) the article
  • Click on the versions button

Actual result BEFORE applying this Pull Request

Different versions are displayed.

Expected result AFTER applying this Pull Request

Different versions are displayed.

avatar laoneo laoneo - open - 30 May 2022
avatar laoneo laoneo - change - 30 May 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 May 2022
Category Front End Plugins
avatar laoneo laoneo - change - 31 May 2022
Labels Added: ?
avatar sandewt
sandewt - comment - 6 Jun 2022

[4.2] Convert versionable plugin to services

Just a question. Does this conversion also work in [4.1] ?

avatar laoneo
laoneo - comment - 7 Jun 2022

[4.2] Convert versionable plugin to services

Just a question. Does this conversion also work in [4.1] ?

Basically it should also work on 4.1. Why?

avatar sandewt
sandewt - comment - 7 Jun 2022

Basically it should also work on 4.1. Why?

I'm building some plugins for 4.1.

avatar laoneo
laoneo - comment - 7 Jun 2022

Ah yes, that should work too.

avatar joomdonation joomdonation - test_item - 11 Jun 2022 - Tested successfully
avatar joomdonation
joomdonation - comment - 11 Jun 2022

I have tested this item successfully on 804666b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37929.

avatar sandewt sandewt - test_item - 11 Jun 2022 - Tested successfully
avatar sandewt
sandewt - comment - 11 Jun 2022

I have tested this item successfully on 804666b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37929.

avatar Quy Quy - change - 11 Jun 2022
Status Pending Ready to Commit
avatar Quy
Quy - comment - 11 Jun 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37929.

avatar roland-d roland-d - change - 12 Jun 2022
Labels Added: ?
avatar roland-d roland-d - change - 12 Jun 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-06-12 09:12:39
Closed_By roland-d
avatar roland-d roland-d - close - 12 Jun 2022
avatar roland-d roland-d - merge - 12 Jun 2022
avatar roland-d
roland-d - comment - 12 Jun 2022

Thanks everybody

Add a Comment

Login with GitHub to post a comment