? ? Pending

User tests: Successful: Unsuccessful:

avatar cyrezdev
cyrezdev
28 May 2022

Pull Request to add inlinehelp toggle button (PR #35610) in edit view.

Since PR #37158 already integrates inlinehelp button in com_content config, if it's ok with this PR, i will be able to integrate toggle button for inlinehelp in each core components.

Summary of Changes

  • Add inlinehelp button in com_content > Article > edit

Testing Instructions

  • Edit an article and play with inlinehelp toggle button.

Actual result BEFORE applying this Pull Request

  • no inlinehelp button
  • description shown

Expected result AFTER applying this Pull Request

  • Inlinehelp toggle button in toolbar next to help button.
  • Descriptions hidden by default
avatar cyrezdev cyrezdev - open - 28 May 2022
avatar cyrezdev cyrezdev - change - 28 May 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 May 2022
Category Administration com_content
avatar cyrezdev cyrezdev - change - 28 May 2022
The description was changed
avatar cyrezdev cyrezdev - edited - 28 May 2022
avatar conseilgouz
conseilgouz - comment - 30 May 2022

inlinehelp button added in modules/plugins : see #37915

avatar conseilgouz
conseilgouz - comment - 2 Jun 2022

for information, #37915 hides inlinehelp toogle button if no description has been defined in extension xml file.

avatar conseilgouz conseilgouz - test_item - 2 Jun 2022 - Tested successfully
avatar conseilgouz
conseilgouz - comment - 2 Jun 2022

I have tested this item successfully on 580ceb5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37917.

avatar cyrezdev
cyrezdev - comment - 2 Jun 2022

for information, #37915 hides inlinehelp toogle button if no description has been defined in extension xml file.

Good addition! I was thinking about it too...
I will try to test your PR tomorrow ;-)

avatar Quy Quy - test_item - 2 Jun 2022 - Tested successfully
avatar Quy
Quy - comment - 2 Jun 2022

I have tested this item successfully on 580ceb5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37917.

avatar Quy Quy - change - 2 Jun 2022
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 2 Jun 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37917.

avatar bembelimen bembelimen - change - 5 Jun 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-06-05 22:19:17
Closed_By bembelimen
Labels Added: ?
avatar bembelimen bembelimen - close - 5 Jun 2022
avatar bembelimen bembelimen - merge - 5 Jun 2022
avatar bembelimen
bembelimen - comment - 5 Jun 2022

Thx

Add a Comment

Login with GitHub to post a comment