[#37861] - [4] com_content.article view. Remove redundant `if $this->item->pagination`
- Fixed in Code Base
- 28 May 2022
- Medium
- Build: 4.1-dev
- # 37861
- Diff
- ReLater:patch-2
User tests: Successful: Unsuccessful:
Summary of Changes
- The second part of condition
!empty($this->item->pagination) && $this->item->paginationis redundant. "If it's not empty then it is" ;-) - See other similar code lines in the file where this double check has been removed already a long time ago.
Testing Instructions
- Code review.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37861.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37861.
I cannot find the code in may 4.1-dev branch.
https://github.com/joomla/joomla-cms/blob/4.1-dev/components/com_content/tmpl/article/default.php#L138
This change was made a year ago 733786f
or am I missing something?
I cannot find the code in may 4.1-dev branch. https://github.com/joomla/joomla-cms/blob/4.1-dev/components/com_content/tmpl/article/default.php#L138 This change was made a year ago 733786f or am I missing something?
@chmst Your link goes to line 138, but this PR changes line 95. The old commit changed line 43.
oops - thanks, this code needs more improvement ;)
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-05-28 19:09:43 |
| Closed_By | ⇒ | Quy |
Thanks
I have tested this item✅ successfully on f2b8703
Tested successfully in Joomla 4.1.4-rc2-dev of 23 May.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37861.