[#3786] - [#33868] Only show published content in mod_tags_popular
- Closed
- 9 Jul 2014
- Medium
- Build: staging
- # 3786
- Diff
- Harmageddon:mod_tags_popular_only_published
- Foreign ID 33868
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
The "Popular Tags" module shows tags from all tagged items, regardless of their respective publishing status. If you have an article that is not published yet tagged with "Tag1", this tag shows in "Popular Tags" with 1 article, but if you click on the link for the article list, no article is shown.
Testing instructions:
- Create a mod_tags_popular module (optionally: enable "Display number of items")
- Create a taggable item (e.g. an article) and tag it.
- Set the item's status to "unpublished".
- Look at the module's output in frontend.
- Set the item to published, but with a future publish date.
- Look at the module's output in frontend.
- Set the item to published, but with a past de-publish date.
- Look at the module's output in frontend.
- Apply the patch and repeat steps 3-5.
Please be aware that there are more taggable item types than just articles. I tested it with articles and contacts without any problems. And please have a short look at the SQL query, too, to ensure, that everything is correct here. Thanks!
JoomlaCode item: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33868
| Title |
|
||||||
Bakual
- | Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-07-09 19:40:35 |
@test: Works as expected, the tag no longer shows up when the article is unpublished, has a future publish date or has a past unpublish date.
There is a codestyle issue with the patch though:
:33: trailing whitespace.
->join('INNER', $db->quoteName('#__ucm_content', 'c') . ' ON ' . $db->quoteName('m.core_content_id') . ' = ' . $db->quoteName('c.core_content_id'))
:36: trailing whitespace.
warning: 2 lines add whitespace errors.
Please fix that and we can move it forward.