Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#37844] - [4.4] Container Database

bug ? PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
21 May 2022

Summary of Changes

Use ClassName instead of hardcoded string

Joomla\Database\DatabaseInterface is also used. What should be used: DatabaseDriver or DatabaseInterface

Testing Instructions

Use your website (for eg. download the 'System Information' or use Webauthn)

Code Review

avatar heelc29 heelc29 - open - 21 May 2022
avatar heelc29 heelc29 - change - 21 May 2022
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 May 2022
Category ⇒ Administration com_admin Modules Libraries Front End Plugins
avatar laoneo
laoneo - comment - 21 May 2022

Can you change them to the DatabaseInterface::class? Better to use the interface, so we can put into the container anything which implements it and do not add the requirement to be a driver.

avatar heelc29 heelc29 - change - 23 May 2022
Labels Added: ?
avatar heelc29
heelc29 - comment - 23 May 2022

Can you change them to the DatabaseInterface::class?

@laoneo Done

avatar laoneo
laoneo - comment - 13 Jun 2022

Can you rebase this pr to 4.2 please? There we should use the injected database whenever possible.

avatar heelc29 heelc29 - change - 13 Jun 2022
Title
…
[4.1] Container Database
[4.2] Container Database
avatar heelc29 heelc29 - edited - 13 Jun 2022
avatar heelc29 heelc29 - change - 13 Jun 2022
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 13 Jun 2022
Category Administration com_admin Modules Libraries Front End Plugins ⇒ Administration com_admin com_installer com_users Modules Libraries Front End Plugins
avatar heelc29
heelc29 - comment - 13 Jun 2022

Can you rebase this pr to 4.2 please?

@laoneo Done.

avatar laoneo laoneo - change - 13 Jun 2022
Labels Removed: ?
avatar joomdonation joomdonation - test_item - 25 Jun 2022 - Tested successfully
avatar joomdonation
joomdonation - comment - 25 Jun 2022

I have tested this item ✅ successfully on c15f5a8

Applied patch, access to various functions like System Information, Users Manage, Articles Manage, Add/edit user/article, view article where tags displayed...., nothing is broken. Done a code review, too.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37844.

avatar joomla-bot
joomla-bot - comment - 27 Jun 2022

This pull requests has been automatically converted to the PSR-12 coding standard.

avatar HLeithner HLeithner - change - 27 Jun 2022
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 27 Jun 2022
Category Administration com_admin Modules Libraries Front End Plugins com_installer com_users ⇒ Administration com_admin com_installer com_users Modules Repository Libraries Front End Plugins
avatar joomla-cms-bot joomla-cms-bot - change - 1 Aug 2022
Category Administration com_admin Modules Libraries Front End Plugins com_installer com_users Repository ⇒ Administration com_admin com_installer com_users Modules Libraries Front End Plugins
avatar HLeithner
HLeithner - comment - 2 May 2023

This pull request has been automatically rebased to 4.3-dev.

avatar heelc29 heelc29 - change - 20 May 2023
Labels Added: bug ?
Removed: ?
avatar heelc29 heelc29 - change - 20 May 2023
Title
…
[4.2] Container Database
[4.3] Container Database
avatar heelc29 heelc29 - edited - 20 May 2023
avatar heelc29 heelc29 - change - 5 Jun 2023
Labels Added: PR-4.3-dev
Removed: ?
avatar laoneo
laoneo - comment - 28 Jun 2023

Can you rebase to 4.4? Thanks for your patience...

avatar laoneo laoneo - change - 28 Jun 2023
Title
…
[4.3] Container Database
[4.4] Container Database
avatar laoneo laoneo - edited - 28 Jun 2023
avatar laoneo
laoneo - comment - 28 Jun 2023

Now there is a conflict. Once solved, I will merge it.

Fixed it.

avatar laoneo laoneo - change - 28 Jun 2023
Labels Removed: PR-4.3-dev
avatar heelc29
heelc29 - comment - 28 Jun 2023

Fixed it.

Thanks

avatar laoneo laoneo - close - 28 Jun 2023
avatar laoneo laoneo - merge - 28 Jun 2023
avatar laoneo laoneo - change - 28 Jun 2023
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-06-28 11:11:12
Closed_By ⇒ laoneo
Labels Added: PR-4.4-dev
avatar laoneo
laoneo - comment - 28 Jun 2023

Thanks!

Add a Comment

Login with GitHub to post a comment