? Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar nikosdion
nikosdion
20 May 2022

Summary of Changes

Adds a Package filter in the Extensions: Manage page.

Testing Instructions

Go to System, Manage, Extensions

Actual result BEFORE applying this Pull Request

Filtering the list of extensions by the extension package ID they belong to is not possible.

Expected result AFTER applying this Pull Request

You have a Package dropdown filter. Choosing a package shows you that package extension and all extensions Joomla knows belong to that package (based on the recorded package_id in the database).

Documentation Changes Required

You need to document the Package filter:

  • Package. Displays only the selected "package" type extension and all extensions which belong to it. Note: You should only uninstall the "package" type extension to prevent extension and core Joomla update problems.

Translation Changes Required

Two translation keys were added

Reasoning for this PR

It is very important that users only ever try to uninstall the "package" extension, not the individual extensions a package contains. Failing to do so will cause all sorts of problems:

  • Trying to uninstall the package extension displays warnings about missing extensions which cannot be uninstalled.
  • Some packages fail to uninstall because their installation scripts expect one or more of the included extensions to be present when the package uninstallation takes place.
  • Removing all included extensions but not the package itself will find updates. Installing the updates reinstalls the missing extensions which can be confusing and disorienting for the user.
  • Removing some of the extensions included in a package, for example some plugins, may cause the other extensions to fail in unpredictable ways.

Right now the only indication that an extension is part of a package is the meaningless Package ID column. Ask 100 users what that is for and 99 will have no idea.

Even worse, those of us who do know what it is cannot filter by a package ID, making it extremely hard to locate all extensions which belong to a package. We would have to search for the package name, note down the package ID, clear the filter, sort the list by package ID, start going through the pagination until we find the package ID in question in the rightmost column and carefully examine which extensions it contains. This is a very Soviet user experience, the only thing missing are the people in long coats asking us to please follow them to the back room for questioning.

With a filter like that it's easy to pinpoint the extensions included in a package, complete with the package itself. This makes management far easier on real world sites (default installations don't really have any packages, rendering this a moot point — but almost nobody runs Joomla like that in the real world).

avatar nikosdion nikosdion - open - 20 May 2022
avatar nikosdion nikosdion - change - 20 May 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 May 2022
Category Administration com_installer Language & Strings
avatar nikosdion nikosdion - change - 20 May 2022
Labels Added: Language Change ?
avatar SumCompanyInc
SumCompanyInc - comment - 21 May 2022

I have tested this item successfully on 7473cca


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37838.

avatar SumCompanyInc SumCompanyInc - test_item - 21 May 2022 - Tested successfully
avatar alikon alikon - test_item - 21 May 2022 - Tested successfully
avatar alikon
alikon - comment - 21 May 2022

I have tested this item successfully on 7473cca


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37838.

avatar alikon alikon - change - 21 May 2022
Status Pending Ready to Commit
avatar alikon
alikon - comment - 21 May 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37838.

avatar bembelimen
bembelimen - comment - 5 Jun 2022

Nice addition, but I will move to 4.2 and ping @roland-d to merge is asap.

avatar bembelimen bembelimen - change - 5 Jun 2022
Labels Added: ?
avatar nikosdion
nikosdion - comment - 6 Jun 2022

@bembelimen No problem and thank you!

avatar roland-d roland-d - change - 6 Jun 2022
Labels Added: ?
Removed: ?
avatar roland-d roland-d - change - 6 Jun 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-06-06 16:56:21
Closed_By roland-d
avatar roland-d roland-d - close - 6 Jun 2022
avatar roland-d roland-d - merge - 6 Jun 2022
avatar roland-d
roland-d - comment - 6 Jun 2022

Thanks everybody

Add a Comment

Login with GitHub to post a comment