? ? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
16 May 2022

Pull Request for Issue #37812

Summary of Changes

Restore the existing behavior before the regression caused by #37395 as well as fix the Issue from the original report

Testing Instructions

  • setup a 4.1.2 site
  • create 2 menus
  • create one menu items for the first menu
  • open that menu item in edit mode
  • change the menu setting to the seccond menu
  • Use the "save2copy" feature.
  • the change to the menu setting is ignored
  • update to 4.1.3
  • repeat the steps from above
  • it works
  • but try it without changing the assigned menu
  • it fails as the alias exists already
  • apply the patch
  • confirm that both cases still work as expected
  • try to only change the menu item title
  • save2copy
  • confirm that the alias number is not just increased but followed the change to the menu title
  • try to only change the alias but keep the title
  • save2copy
  • confirm that the alias has been updated but not the title.

Actual result BEFORE applying this Pull Request

Issues of "alias exists already" while with save2copy we have an "increment the ID" feature

Expected result AFTER applying this Pull Request

The alias will be updated as expected any by using save2copy you should not get alias dubliceted issues.

Documentation Changes Required

n.a

Mentions

@toivo
@bembelimen

Involved within the PR which caused the regression:
@anmode
@chmst
@richard67
@vorayash
@Quy

avatar zero-24 zero-24 - open - 16 May 2022
avatar zero-24 zero-24 - change - 16 May 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 May 2022
Category Administration com_menus
avatar zero-24 zero-24 - change - 16 May 2022
Labels Added: ?
avatar toivo
toivo - comment - 17 May 2022

I have tested this item successfully on 096a742

Tested successfully in 4.1.2 upgraded to 4.1.3 and patched, using PHP 8.0.15.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37813.

avatar toivo toivo - test_item - 17 May 2022 - Tested successfully
avatar Webdongle
Webdongle - comment - 17 May 2022

I have tested this item successfully on 096a742

Full success


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37813.

avatar Webdongle Webdongle - test_item - 17 May 2022 - Tested successfully
avatar richard67 richard67 - change - 17 May 2022
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 17 May 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37813.

avatar bembelimen bembelimen - change - 18 May 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-05-18 15:08:06
Closed_By bembelimen
Labels Added: ? ?
avatar bembelimen bembelimen - close - 18 May 2022
avatar bembelimen bembelimen - merge - 18 May 2022
avatar bembelimen
bembelimen - comment - 18 May 2022

Thx

Add a Comment

Login with GitHub to post a comment