[#37809] - [4.2] Limit language overrides search results to selected language
- Fixed in Code Base
- 21 May 2022
- Medium
- Build: 4.2-dev
- # 37809
- Diff
- Bakual:4_OnlyProcessSelectedLanguage
User tests: Successful: Unsuccessful:
Pull Request for Issue #37779 .
Summary of Changes
Added a simple check to the filepath if the current language is part of it. If not, the file is skipped.
I've excluded the base path from the check so it doesn't get triggered if someone has Joomla stored eg within a folder "en-GB" (you never know...).
Testing Instructions
- Search for a language constant from a 3rd party extension which has their files stored in its extension directory (eg DP Calendar or my own SermonSpeaker will do).
Actual result BEFORE applying this Pull Request
String are shown for all available languages
Expected result AFTER applying this Pull Request
Strings are limited to the selected language
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_languages |
I dunno. I just had a 4.2 installation and worked with that. I guess it would be just copy paste for other branches.
If you want to fix it in 3.x, I can make one for J3 and you guys just upmerge it to J4. But it's likely a very longstanding issue, so not sure if it needs to be fixed in J3
@joomleb Please mark your test result here in the issue tracker, using the blue "Test this" button, then selecting your test result and then submitting: https://issues.joomla.org/tracker/joomla-cms/37809 . Thanks in advance.
I have tested this item
Perfect
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37809.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37809.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37809.
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
I see no reason to not backport this to 3.x and 4.1.
After all, this is a bug.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-05-21 17:31:45 |
| Closed_By | ⇒ | roland-d |
Thanks everybody
@Bakual Will you make a PR for 3.10-dev, too? Am asking because the issue was for both 3.10 and 4.1. Am not sure if I shall close the issue now or if I shall wait for a 3.10-dev PR.
Update: I meanwhile saw this PR is for 4.2-dev and not 4.1-dev. So it's a kind of new feature? If so, just ignore my comment above.